Skip to content

Conversation

@raed667
Copy link
Contributor

@raed667 raed667 commented Nov 4, 2025

🧭 What and Why

Recommend's Frequently bought together model supports fallbackParameters

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/RECO-2443

Changes included:

  • Add fallbackParameters to the spec
@raed667 raed667 requested a review from a team as a code owner November 4, 2025 17:12
@raed667 raed667 requested review from Fluf22 and morganleroi November 4, 2025 17:12
@algolia-bot
Copy link
Collaborator

algolia-bot commented Nov 4, 2025

💥 Breaking changes detected !!

Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging.
You can find the details in the 'client java@21' CI job.

✔️ Code generated!

Name Link
🪓 Triggered by 18f0776c43ac89d284d7a3fad9cf92ad04cc9ad2
🍃 Generated commit de78fc97169db8d07bee7165c3cd6e61b215f9aa
🌲 Generated branch generated/feat/spec/recommend/fbt-fallback-params
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 2421
go 2259
php 2143
csharp 1746
python 1359
java 1199
ruby 888
swift 594
scala 23
Copy link
Contributor

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great ! is this ready to be released ?

@raed667
Copy link
Contributor Author

raed667 commented Nov 5, 2025

Thanks !

Yes it can be released, i'll update the documentation and InstantSearch after the release of the spec.

@millotp millotp merged commit ff4b8f0 into main Nov 5, 2025
53 of 56 checks passed
@millotp millotp deleted the feat/spec/recommend/fbt-fallback-params branch November 5, 2025 09:28
algolia-bot added a commit that referenced this pull request Nov 5, 2025
…CO-2443] (#5579) (generated) [skip ci] Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Nov 5, 2025
…CO-2443] (generated) algolia/api-clients-automation#5579 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Nov 5, 2025
…CO-2443] (generated) algolia/api-clients-automation#5579 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Nov 5, 2025
…CO-2443] (generated) algolia/api-clients-automation#5579 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Nov 5, 2025
…CO-2443] (generated) algolia/api-clients-automation#5579 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Nov 5, 2025
…CO-2443] (generated) algolia/api-clients-automation#5579 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Nov 5, 2025
…CO-2443] (generated) algolia/api-clients-automation#5579 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Nov 5, 2025
…CO-2443] (generated) algolia/api-clients-automation#5579 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Nov 5, 2025
…CO-2443] (generated) algolia/api-clients-automation#5579 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Nov 5, 2025
…CO-2443] (generated) algolia/api-clients-automation#5579 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Nov 5, 2025
…CO-2443] (generated) algolia/api-clients-automation#5579 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Raed <raed.chammam@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Nov 5, 2025
…CO-2443] (generated) algolia/api-clients-automation#5579 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Raed <raed.chammam@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants