Skip to content

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Oct 20, 2025

🧭 What and Why

The replaceAllObjectsWithTransformation helper already uses getEvent, the watch parameter in push should be false, otherwise it waits twice.

@millotp millotp self-assigned this Oct 20, 2025
@millotp millotp requested a review from a team as a code owner October 20, 2025 13:43
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 20, 2025

💥 Breaking changes detected !!

Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging.
You can find the details in the 'client java@21' CI job.

✔️ Code generated!

Name Link
🪓 Triggered by c6142015a564d8b70860b0accf92e7363c763d7e
🍃 Generated commit 84d66f8fa4d5049f2671d747dd7f31b732cc8234
🌲 Generated branch generated/fix/wait-java
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1759
javascript 1614
php 1474
csharp 1339
python 1092
java 1005
ruby 788
swift 285
scala 23
shortcuts
shortcuts previously approved these changes Oct 20, 2025
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oopsie

@millotp millotp merged commit dacf940 into main Oct 20, 2025
54 of 56 checks passed
@millotp millotp deleted the fix/wait-java branch October 20, 2025 15:15
algolia-bot added a commit that referenced this pull request Oct 20, 2025
…#5516) (generated) [skip ci] Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Oct 20, 2025
… (generated) algolia/api-clients-automation#5516 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants