- Notifications
You must be signed in to change notification settings - Fork 28
feat(specs): add compositions deduplication setting #5418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
e9cd1cc to 3d93cf1 Compare 6fea709 to e3cc3d5 Compare eecd9af to bcab941 Compare bcab941 to 0ea81d5 Compare
ClaraMuller left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these updates are used in documentation.
I had feedback that these values are not clear.
See PR #5419
Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
| @ben-kalmus Sorry I was asked to again modify the values for the key |
No problem, I renamed it to |
millotp left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks ! the generation looks good
…d) [skip ci] Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia/api-clients-automation#5418 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia/api-clients-automation#5418 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia/api-clients-automation#5418 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia/api-clients-automation#5418 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia/api-clients-automation#5418 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia/api-clients-automation#5418 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia/api-clients-automation#5418 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia/api-clients-automation#5418 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia/api-clients-automation#5418 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia/api-clients-automation#5418 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
algolia/api-clients-automation#5418 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Ben Kalmus <ben.kalmus@algolia.com> Co-authored-by: Clara Muller <5667350+ClaraMuller@users.noreply.github.com>
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/CMP-539
Changes included:
🧪 Test
CTS