Skip to content

Conversation

@millotp
Copy link
Collaborator

@millotp millotp commented May 24, 2022

🧭 What and Why

Renovate is trying to update the deps in our generated clients, we don't want that.

@millotp millotp requested review from eunjae-lee and shortcuts May 24, 2022 08:14
@millotp millotp self-assigned this May 24, 2022
@netlify
Copy link

netlify bot commented May 24, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 62b8411
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/628c95a44bc5c50009b9b9be
@algolia-bot
Copy link
Collaborator

algolia-bot commented May 24, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@millotp millotp enabled auto-merge (squash) May 24, 2022 08:15
renovate.json Outdated
Comment on lines 24 to 32
"**/client-abtesting/**",
"**/client-analytics/**",
"**/client-insights/**",
"**/client-personalisation/**",
"**/client-predict/**",
"**/client-query-suggestions/**",
"**/client-search/**",
"**/client-sources/**",
"**/recommend/**"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it take negative patterns? Might be easier to only ignore manually written clients

Copy link
Collaborator Author

@millotp millotp May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clients/algoliasearch-client-javascript/package.json clients/algoliasearch-client-javascript/packages/algoliasearch-lite/package.json clients/algoliasearch-client-javascript/packages/algoliasearch/package.json clients/algoliasearch-client-javascript/packages/client-abtesting/package.json clients/algoliasearch-client-javascript/packages/client-analytics/package.json clients/algoliasearch-client-javascript/packages/client-common/package.json clients/algoliasearch-client-javascript/packages/client-insights/package.json clients/algoliasearch-client-javascript/packages/client-personalization/package.json clients/algoliasearch-client-javascript/packages/client-predict/package.json clients/algoliasearch-client-javascript/packages/client-query-suggestions/package.json clients/algoliasearch-client-javascript/packages/client-search/package.json clients/algoliasearch-client-javascript/packages/client-sources/package.json clients/algoliasearch-client-javascript/packages/recommend/package.json clients/algoliasearch-client-javascript/packages/requester-browser-xhr/package.json clients/algoliasearch-client-javascript/packages/requester-node-http/package.json eslint/package.json package.json playground/javascript/browser/package.json playground/javascript/node/package.json scripts/package.json website/package.json tests/output/javascript/package.json 

10 generated package.json and 12 hand written !

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tests package is already ignored for some reason

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant for the client JS only, like

!clients/algoliasearch-client-javascript/packages/requester-*/** !clients/algoliasearch-client-javascript/packages/client-common/** 

So later we don't have to worry if we add JS clients

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try, it doesn't says if it's supported in the doc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem then! Also you can add algoliasearch and algoliasearch-lite to the list if it does not work

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it has to be merged to try 😁

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's see!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants