Skip to content

Conversation

@Haroenv
Copy link
Contributor

@Haroenv Haroenv commented May 18, 2022

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-486

The key of the headers actually is called algolia agent, and this way it stays compatible with older versions too!

Changes included:

  • global find and replace for userAgent to algoliaAgent (matching case)
  • I've not changed anything in clients/, as i that is generated (can do if needed)

🧪 Test

?

@Haroenv Haroenv requested review from bodinsamuel and shortcuts May 18, 2022 08:20
@netlify
Copy link

netlify bot commented May 18, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 809b1be
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/6284b87f980b8c00090f6ca2
@Haroenv Haroenv marked this pull request as draft May 18, 2022 08:21
@algolia-bot
Copy link
Collaborator

algolia-bot commented May 18, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.

@shortcuts
Copy link
Member

Thanks! Will follow in https://algolia.atlassian.net/browse/APIC-486 for the generated part etc :D

@shortcuts shortcuts changed the title feat(headers): rename userAgent to algoliaAgent feat(templates): rename userAgent to algoliaAgent May 18, 2022
@shortcuts shortcuts force-pushed the feat/algolia-agent branch from 4475a9b to 48db0ad Compare May 18, 2022 08:42
@shortcuts shortcuts force-pushed the feat/algolia-agent branch from b3aa778 to 809b1be Compare May 18, 2022 09:12
@shortcuts shortcuts marked this pull request as ready for review May 18, 2022 09:25
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ty for doing it :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants