chore(all): factor the version into clients.config.json #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts reviewed May 12, 2022
| return clientsConfig[language].customGenerator; | ||
| } | ||
| | ||
| export function getPackageVersionDefault(language: Language): string { |
There was a problem hiding this comment.
Can we add a description with the case for js pls?
eunjae-lee reviewed May 12, 2022
eunjae-lee suggested changes May 12, 2022
| } | ||
| | ||
| // doens't work for javascript | ||
| public static String getPackageVersion(String language) { |
There was a problem hiding this comment.
Let's throw an error when language.equals("javascript") with a proper explanation. We will forget this 6 months later, or someone else looking at this code will be lost.
eunjae-lee previously approved these changes May 12, 2022
| Last review sorry I messed up with the exceptions |
shortcuts approved these changes May 12, 2022
This was referenced May 19, 2022
This was referenced May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
After talk at the tech sync, we decided that spec version are irrelevant and only clients version matter, and to reduce duplication they are now defined in
clients.config.json(except for js, of course).Changes included:
mainPackagebypackageVersion🧪 Test
CI