Skip to content

chore: fix specs deps #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2022
Merged

chore: fix specs deps #478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa95bc1
chore: fix specs deps
shortcuts May 6, 2022
aedc641
rename specs deps
shortcuts May 6, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ outputs:
value: ${{
steps.diff.outputs.GITHUB_ACTIONS_CHANGED > 0 ||
steps.diff.outputs.SCRIPTS_CHANGED > 0 ||
steps.diff.outputs.SPECS_CHANGED > 0 ||
steps.diff.outputs.SHOULD_RUN_SPECS > 0 ||
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's only used here then you can remove the check for TEMPLATE_CHANGED, as it's included in SHOULD_RUN_SPECS
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be in favor of doing the clean in a later PR as I'm not sure anything else won't break D:
steps.diff.outputs.TESTS_CHANGED > 0 ||
steps.diff.outputs.JS_CLIENT_CHANGED > 0 ||
steps.diff.outputs.JS_TEMPLATE_CHANGED > 0 ||
Expand Down
8 changes: 7 additions & 1 deletion scripts/ci/githubActions/setRunVariables.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,13 @@ export const DEPENDENCIES = {
'.github/workflows',
'.github/.cache_version',
],
SPECS_CHANGED: ['specs', ':!specs/bundled'],
SHOULD_RUN_SPECS: [
...CLIENTS_COMMON_FILES,
'specs',
'templates',
'generators',
':!specs/bundled',
],
COMMON_SPECS_CHANGED: ['specs/common'],
TESTS_CHANGED: ['tests'],
SCRIPTS_CHANGED: ['scripts'],
Expand Down