chore: simplify openapi #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts reviewed May 5, 2022
| [] as string[] | ||
| ); | ||
| const AVAILABLE_CUSTOM_GEN = Object.values(clientsConfig) | ||
| .map((gen) => ('customGenerator' in gen ? gen.customGenerator : null)) |
| "topLevelDomain": "com", | ||
| "utilsPackageVersion": "0.2.0" | ||
| "utilsPackageVersion": "0.2.0", | ||
| "hasRegionalHost": true |
This was referenced May 19, 2022
This was referenced May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Ticket: APIC-474
The fix package is now deprecated in favor of the real
openapi-generator-clipackage which now contains the fix for custom generators.Use this opportunity to simplify our
openapitools.jsonfile and put it in theconfigfolder.When we generate code or CTS, we now generate the final
openapitools.jsonfile from the config one, and feed it toopenapi-generator-cli. This way we can have minimal information in our config file.Move all the server setup to the generators instead of openapitools, to have better control.
🧪 Test
CI