chore: fix release issue #447
Conversation
✅ Deploy Preview for api-clients-automation canceled.
|
| if (!(await isAuthorizedRelease())) { | ||
| throw new Error( | ||
| console.log( | ||
| 'The issue was not approved.\nA team member must leave a comment "approved" in the release issue.' | ||
| ); | ||
| return; | ||
| } |
There was a problem hiding this comment.
This was making the CI fail, I think it's enough but let me know if it was intended @eunjae-lee
There was a problem hiding this comment.
There was a problem hiding this comment.
Yeah it is intended. If we decide not to release an issue, then we can just close it, which ends up failing on the CI, but we can still ignore it.
On the other hand, someone leaves a comment with a typo like aproved, then it should explicitly fail, so that we know.
There was a problem hiding this comment.
restored here: 4cdcbfa
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
| <ul> | ||
| ${commitsWithUnknownLanguageScope.map((commit) => `<li>${commit}</li>`)} | ||
| </ul>`; | ||
| return `</p> |
There was a problem hiding this comment.
| return `</p> | |
| return `<p></p> |
it was that actually, to make a space. (you need to update the tests as well)
There was a problem hiding this comment.
Don't you think it look nice on the preview? #446
There was a problem hiding this comment.
when do you open the <p> ?
| <ul> | ||
| ${commitsWithUnknownLanguageScope.map((commit) => `<li>${commit}</li>`)} | ||
| </ul>`; | ||
| return `</p> |
There was a problem hiding this comment.
when do you open the <p> ?
4 participants
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
The format of the release issue was a bit broken (see #445), so I've updated it #446
🧪 Test
Before: #445
After: #446