Skip to content

chore(ci): include common changes to cache version #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 27, 2022
Merged

chore(ci): include common changes to cache version #433

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
5bcac1a
chore(ci): include common changes to cache version
millotp Apr 26, 2022
7423299
run yarn install before
millotp Apr 26, 2022
42270c9
test
millotp Apr 26, 2022
0dc94ad
wrong key
millotp Apr 26, 2022
98ccb34
remove char
millotp Apr 26, 2022
4a3caee
export to GITHUB_ENV
millotp Apr 26, 2022
4a3ea86
Merge branch 'main' into chore/cache-common
millotp Apr 26, 2022
164ef77
try @shortcuts idea
millotp Apr 26, 2022
2ee50f2
java
millotp Apr 26, 2022
71b474d
pass around
millotp Apr 26, 2022
6a75a75
use hex and needs
millotp Apr 26, 2022
384a5f1
Merge branch 'main' into chore/cache-common
millotp Apr 26, 2022
d74e52f
try with jobs.setup
millotp Apr 27, 2022
38c92ff
add setup to needs
millotp Apr 27, 2022
7858c34
@eunjae-lee suggestion
millotp Apr 27, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 46 additions & 41 deletions .github/actions/cache/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,18 @@ inputs:
language:
description: The language to retrieve dependencies.
required: false
cache_hash:
description: The cache hash from github actions and scripts
required: false

runs:
using: composite
steps:
- name: Read current GitHub Actions cache version
shell: bash
run: echo "CACHE_VERSION=$(< .github/.cache_version)" >> $GITHUB_ENV
run: |
echo "CACHE_VERSION=$(< .github/.cache_version)" >> $GITHUB_ENV
echo "CACHE_COMMON_HASH=${{ inputs.cache_hash }}" >> $GITHUB_ENV
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if we concatenate .cache_version and cash_hash and assign to CACHE_VERSION?
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that at first but CACHE_VERSION only is needed for yarn cache, because we need yarn to build CACHE_COMMON_HASH.
Actually it could be in it's own variable, that would make more sense, but it still needs to be passed around everywhere
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay, it makes sense. Tough problem 😅
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's much cleaner like that thank you :)

# JavaScript setup
- name: Get yarn cache directory path
Expand All @@ -42,7 +47,7 @@ runs:
with:
path: specs/bundled/abtesting.yml
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'specs/abtesting/**',
'specs/common/**'
Expand All @@ -54,7 +59,7 @@ runs:
with:
path: specs/bundled/analytics.yml
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'specs/analytics/**',
'specs/common/**'
Expand All @@ -66,7 +71,7 @@ runs:
with:
path: specs/bundled/insights.yml
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'specs/insights/**',
'specs/common/**'
Expand All @@ -78,7 +83,7 @@ runs:
with:
path: specs/bundled/personalization.yml
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'specs/personalization/**',
'specs/common/**'
Expand All @@ -90,7 +95,7 @@ runs:
with:
path: specs/bundled/predict.yml
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'specs/predict/**',
'specs/common/**'
Expand All @@ -102,7 +107,7 @@ runs:
with:
path: specs/bundled/query-suggestions.yml
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'specs/query-suggestions/**',
'specs/common/**'
Expand All @@ -114,7 +119,7 @@ runs:
with:
path: specs/bundled/recommend.yml
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'specs/recommend/**',
'specs/common/**'
Expand All @@ -126,7 +131,7 @@ runs:
with:
path: specs/bundled/search.yml
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'specs/search/**',
'specs/common/**'
Expand All @@ -138,7 +143,7 @@ runs:
with:
path: specs/bundled/algoliasearch-lite.yml
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'specs/search/**',
'specs/common/**'
Expand All @@ -150,7 +155,7 @@ runs:
with:
path: specs/bundled/sources.yml
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'specs/sources/**',
'specs/common/**'
Expand All @@ -163,7 +168,7 @@ runs:
with:
path: clients/algoliasearch-client-javascript/packages/client-common
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'clients/algoliasearch-client-javascript/packages/client-common/src/**'
)}}
Expand All @@ -174,7 +179,7 @@ runs:
with:
path: clients/algoliasearch-client-javascript/packages/requester-node-http
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'clients/algoliasearch-client-javascript/packages/requester-node-http/src/**'
)}}
Expand All @@ -185,7 +190,7 @@ runs:
with:
path: clients/algoliasearch-client-javascript/packages/requester-browser-xhr
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'clients/algoliasearch-client-javascript/packages/requester-browser-xhr/src/**'
)}}
Expand All @@ -197,7 +202,7 @@ runs:
with:
path: clients/algoliasearch-client-javascript/packages/algoliasearch
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'clients/algoliasearch-client-javascript/packages/algoliasearch/**',
'clients/algoliasearch-client-javascript/packages/client-search/**',
Expand All @@ -211,7 +216,7 @@ runs:
with:
path: clients/algoliasearch-client-javascript/packages/algoliasearch-lite
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'clients/algoliasearch-client-javascript/packages/algoliasearch-lite/src/**',
'clients/algoliasearch-client-javascript/packages/algoliasearch-lite/model/**',
Expand All @@ -228,7 +233,7 @@ runs:
with:
path: clients/algoliasearch-client-javascript/packages/client-search
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'clients/algoliasearch-client-javascript/packages/client-search/src/**',
'clients/algoliasearch-client-javascript/packages/client-search/model/**',
Expand All @@ -245,7 +250,7 @@ runs:
with:
path: clients/algoliasearch-client-javascript/packages/recommend
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'clients/algoliasearch-client-javascript/packages/recommend/src/**',
'clients/algoliasearch-client-javascript/packages/recommend/model/**',
Expand All @@ -262,7 +267,7 @@ runs:
with:
path: clients/algoliasearch-client-javascript/packages/client-query-suggestions
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'clients/algoliasearch-client-javascript/packages/client-query-suggestions/src/**',
'clients/algoliasearch-client-javascript/packages/client-query-suggestions/model/**',
Expand All @@ -279,7 +284,7 @@ runs:
with:
path: clients/algoliasearch-client-javascript/packages/client-personalization
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'clients/algoliasearch-client-javascript/packages/client-personalization/src/**',
'clients/algoliasearch-client-javascript/packages/client-personalization/model/**',
Expand All @@ -296,7 +301,7 @@ runs:
with:
path: clients/algoliasearch-client-javascript/packages/client-analytics
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'clients/algoliasearch-client-javascript/packages/client-analytics/src/**',
'clients/algoliasearch-client-javascript/packages/client-analytics/model/**',
Expand All @@ -313,7 +318,7 @@ runs:
with:
path: clients/algoliasearch-client-javascript/packages/client-abtesting
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'clients/algoliasearch-client-javascript/packages/client-abtesting/src/**',
'clients/algoliasearch-client-javascript/packages/client-abtesting/model/**',
Expand All @@ -330,7 +335,7 @@ runs:
with:
path: clients/algoliasearch-client-javascript/packages/client-insights
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'clients/algoliasearch-client-javascript/packages/client-insights/src/**',
'clients/algoliasearch-client-javascript/packages/client-insights/model/**',
Expand All @@ -347,7 +352,7 @@ runs:
with:
path: clients/algoliasearch-client-javascript/packages/client-sources
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'clients/algoliasearch-client-javascript/packages/client-sources/src/**',
'clients/algoliasearch-client-javascript/packages/client-sources/model/**',
Expand All @@ -364,7 +369,7 @@ runs:
with:
path: clients/algoliasearch-client-javascript/packages/client-predict
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'clients/algoliasearch-client-javascript/packages/client-predict/src/**',
'clients/algoliasearch-client-javascript/packages/client-predict/model/**',
Expand All @@ -382,7 +387,7 @@ runs:
with:
path: clients/algoliasearch-client-java-2/gradle.properties
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'specs/bundled/search.yml',
'templates/java/**',
Expand All @@ -397,7 +402,7 @@ runs:
clients/algoliasearch-client-java-2/algoliasearch-core/src/com/algolia/api/SearchClient.java
clients/algoliasearch-client-java-2/algoliasearch-core/src/com/algolia/model/search/**
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'specs/bundled/search.yml',
'templates/java/**',
Expand All @@ -412,7 +417,7 @@ runs:
clients/algoliasearch-client-java-2/algoliasearch-core/src/com/algolia/api/RecommendClient.java
clients/algoliasearch-client-java-2/algoliasearch-core/src/com/algolia/model/recommend/**
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'specs/bundled/recommend.yml',
'templates/java/**',
Expand All @@ -427,7 +432,7 @@ runs:
clients/algoliasearch-client-java-2/algoliasearch-core/src/com/algolia/api/PersonalizationClient.java
clients/algoliasearch-client-java-2/algoliasearch-core/src/com/algolia/model/personalization/**
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'specs/bundled/personalization.yml',
'templates/java/**',
Expand All @@ -442,7 +447,7 @@ runs:
clients/algoliasearch-client-java-2/algoliasearch-core/src/com/algolia/api/AnalyticsClient.java
clients/algoliasearch-client-java-2/algoliasearch-core/src/com/algolia/model/analytics/**
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'specs/bundled/analytics.yml',
'templates/java/**',
Expand All @@ -457,7 +462,7 @@ runs:
clients/algoliasearch-client-java-2/algoliasearch-core/src/com/algolia/api/InsightsClient.java
clients/algoliasearch-client-java-2/algoliasearch-core/src/com/algolia/model/insights/**
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'specs/bundled/insights.yml',
'templates/java/**',
Expand All @@ -472,7 +477,7 @@ runs:
clients/algoliasearch-client-java-2/algoliasearch-core/src/com/algolia/api/AbtestingClient.java
clients/algoliasearch-client-java-2/algoliasearch-core/src/com/algolia/model/abtesting/**
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'specs/bundled/abtesting.yml',
'templates/java/**',
Expand All @@ -487,7 +492,7 @@ runs:
clients/algoliasearch-client-java-2/algoliasearch-core/src/com/algolia/api/QuerySuggestionsClient.java
clients/algoliasearch-client-java-2/algoliasearch-core/src/com/algolia/model/querySuggestions/**
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'specs/bundled/query-suggestions.yml',
'templates/java/**',
Expand All @@ -502,7 +507,7 @@ runs:
clients/algoliasearch-client-java-2/algoliasearch-core/src/com/algolia/api/PredictClient.java
clients/algoliasearch-client-java-2/algoliasearch-core/src/com/algolia/model/predict/**
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'specs/bundled/predict.yml',
'templates/java/**',
Expand All @@ -518,7 +523,7 @@ runs:
clients/algoliasearch-client-php/lib/Api/SearchClient.php
clients/algoliasearch-client-php/lib/Model/Search/**
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'specs/bundled/search.yml',
'templates/php/**',
Expand All @@ -533,7 +538,7 @@ runs:
clients/algoliasearch-client-php/lib/Api/RecommendClient.php
clients/algoliasearch-client-php/lib/Model/Recommend/**
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'specs/bundled/recommend.yml',
'templates/php/**',
Expand All @@ -548,7 +553,7 @@ runs:
clients/algoliasearch-client-php/lib/Api/PersonalizationClient.php
clients/algoliasearch-client-php/lib/Model/Personalization/**
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'specs/bundled/personalization.yml',
'templates/php/**',
Expand All @@ -563,7 +568,7 @@ runs:
clients/algoliasearch-client-php/lib/Api/AnalyticsClient.php
clients/algoliasearch-client-php/lib/Model/Analytics/**
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'specs/bundled/analytics.yml',
'templates/php/**',
Expand All @@ -578,7 +583,7 @@ runs:
clients/algoliasearch-client-php/lib/Api/InsightsClient.php
clients/algoliasearch-client-php/lib/Model/Insights/**
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'specs/bundled/insights.yml',
'templates/php/**',
Expand All @@ -593,7 +598,7 @@ runs:
clients/algoliasearch-client-php/lib/Api/AbtestingClient.php
clients/algoliasearch-client-php/lib/Model/Abtesting/**
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'specs/bundled/abtesting.yml',
'templates/php/**',
Expand All @@ -608,7 +613,7 @@ runs:
clients/algoliasearch-client-php/lib/Api/QuerySuggestionsClient.php
clients/algoliasearch-client-php/lib/Model/QuerySuggestions/**
key: |
${{ env.CACHE_VERSION }}-${{
${{ env.CACHE_VERSION }}-${{ env.CACHE_COMMON_HASH }}-${{
hashFiles(
'specs/bundled/query-suggestions.yml',
'templates/php/**',
Expand Down
Loading