Skip to content

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jan 9, 2025

🧭 What and Why

🎟 JIRA Ticket: DI-3373

fixes #4322

@millotp millotp requested a review from a team as a code owner January 9, 2025 09:14
@millotp millotp requested review from Fluf22 and shortcuts January 9, 2025 09:14
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 9, 2025

✔️ Code generated!

Name Link
🪓 Triggered by 099e5ee35b5c61a7a256d80b41e4ed433f572633
🍃 Generated commit 6002cbc18526ca0cc758dab1a2a05d497d3cc998
🌲 Generated branch generated/fix/index-settings
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1638
go 1629
php 1502
csharp 1401
java 1129
python 1070
ruby 839
swift 727
@millotp millotp self-assigned this Jan 9, 2025
@millotp millotp changed the title fix(specs): move customRanking and keepDiacriticsOnCharacters to indexSettings fix(specs): move customRanking and keepDiacriticsOnCharacters to indexSettings [skip-bc] Jan 9, 2025
morganleroi
morganleroi previously approved these changes Jan 9, 2025
Copy link
Contributor

@morganleroi morganleroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@millotp millotp merged commit 1e847f4 into main Jan 9, 2025
28 checks passed
@millotp millotp deleted the fix/index-settings branch January 9, 2025 16:00
algolia-bot added a commit that referenced this pull request Jan 9, 2025
…xSettings [skip-bc] (#4324) (generated) [skip ci] Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Jan 9, 2025
…xSettings [skip-bc] (generated) algolia/api-clients-automation#4324 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Jan 9, 2025
…xSettings [skip-bc] (generated) algolia/api-clients-automation#4324 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Jan 9, 2025
…xSettings [skip-bc] (generated) algolia/api-clients-automation#4324 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Jan 9, 2025
…xSettings [skip-bc] (generated) algolia/api-clients-automation#4324 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jan 9, 2025
…xSettings [skip-bc] (generated) algolia/api-clients-automation#4324 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Jan 9, 2025
…xSettings [skip-bc] (generated) algolia/api-clients-automation#4324 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Jan 9, 2025
…xSettings [skip-bc] (generated) algolia/api-clients-automation#4324 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Jan 9, 2025
…xSettings [skip-bc] (generated) algolia/api-clients-automation#4324 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Jan 9, 2025
…xSettings [skip-bc] (generated) algolia/api-clients-automation#4324 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Jan 9, 2025
…xSettings [skip-bc] (generated) algolia/api-clients-automation#4324 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Jan 9, 2025
…xSettings [skip-bc] (generated) algolia/api-clients-automation#4324 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants