fix(spec): remove tags from specs #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
shortcuts requested review from damcou and eunjae-lee and removed request for a team 
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
eunjae-lee previously approved these changes Apr 22, 2022
| does that means we can now use tags to group requests? |
At the spec level it always worked, but at the generation level it's a bit different. The tags are used to output the main API file, and in our case we don't want to have multiples. I believe we could update the custom gens to only have a single output file, but it might be more complicated than that. For now, we just remove |
eunjae-lee approved these changes Apr 22, 2022
shortcuts added a commit that referenced this pull request Apr 22, 2022
This was referenced Apr 22, 2022
This was referenced Apr 29, 2022
This was referenced May 24, 2022
This was referenced May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-417
Changes included:
Splitting some changes from #413
We don't need tags in specs anymore, as it's defaulted to the name of the client.
🧪 Test
CI :D