chore: make spread codegen commit cleaner #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp reviewed Apr 21, 2022
| | ||
| if (isCodeGenCommit) { | ||
| const hash = commitMessage | ||
| .split(text.commitStartMessage)[1] |
There was a problem hiding this comment.
won't that split on spaces by default ?
There was a problem hiding this comment.
Sorry I'm not sure to understand, could you elaborate pls? D:
There was a problem hiding this comment.
for me this split will juste return generated because you split on spaces
There was a problem hiding this comment.
ah no ok that's a weird use of split ahah, I get it
There was a problem hiding this comment.
I split on text.commitStartMessage which is chore: generated code for commit
There was a problem hiding this comment.
I can change it to a regex if you prefer but it seemed easy enough like this
millotp approved these changes Apr 21, 2022
shortcuts added a commit that referenced this pull request Apr 22, 2022
This was referenced Apr 28, 2022
This was referenced May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
Commits from codegen loses context on other repositories (see algolia/algoliasearch-client-java@80ba40c), this PR aims at providing a link to the commit from the automation repository.
🧪 Test
CI :D