chore: use Client suffix #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
shortcuts requested review from damcou and eunjae-lee and removed request for a team 
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
eunjae-lee reviewed Apr 19, 2022
| Do you know why CTS is failing? |
Yep I believe there was a cache issue, I'll fix it once #385 is merged |
shortcuts force-pushed the chore/use-client-suffix branch from 236f5c4 to a823f21 Compare 
shortcuts force-pushed the chore/use-client-suffix branch from a823f21 to e46ac5c Compare | (trying without the deleted files now to see if GH does the switch, last time it didn't 🤔 ) |
1 task
shortcuts added a commit that referenced this pull request Apr 22, 2022
This was referenced Apr 28, 2022
This was referenced Apr 29, 2022
This was referenced May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-435
Changes included:
We've decided that
Clientwas a more suitable suffix for the generate clients. The only real changes are in thegeneratorsfolder, the rest is mostly renames.For some reason, in #385 we've seen that the deleted files are not pushed, so I've deleted them manually
🧪 Test
CI :D