chore: upgrade typescript version to fix netlify #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp requested review from a team, damcou and shortcuts and removed request for a team 
shortcuts pushed a commit that referenced this pull request Apr 22, 2022
This was referenced May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
The build error in netlify seems to originate from a version discrepancy of typescript in the
eslintfolder,testing if having the same version everywhere makes a difference.
Also simplify
eslintrc.jsby splittingyamlandtscompletely, otherwise theyamlwould fail because it did't have type annotations liketsconfig.json.Netlify error:
YN0000: │ @algolia/api-client-automation@workspace:. STDERR Error: Cannot find module '/opt/build/repo/eslint/node_modules/typescript/bin/tsc'Changes included:
🧪 Test
CI