fix(spec): fix wrong query parameters #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts changed the title shortcuts changed the title shortcuts requested review from a team, damcou and eunjae-lee and removed request for a team 
millotp reviewed Apr 5, 2022
millotp approved these changes Apr 5, 2022
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Apr 5, 2022
algolia/api-clients-automation#330 Co-authored-by: Clément Vannicatte <20689156+shortcuts@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Apr 5, 2022
algolia/api-clients-automation#330 Co-authored-by: Clément Vannicatte <20689156+shortcuts@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Apr 5, 2022
algolia/api-clients-automation#330 Co-authored-by: Clément Vannicatte <20689156+shortcuts@users.noreply.github.com>
shortcuts added a commit that referenced this pull request Apr 22, 2022
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
This was referenced May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-412
Changes included:
Follow up of #313
The method's query parameters accepted only strings, while we could allow an object to ease the usage. This PR updates the spec and templates to reflect this change
🧪 Test
CI :D