Skip to content

Conversation

@eunjae-lee
Copy link
Contributor

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-388

Changes included:

  • Release issue no longer lets you "just update" the repository. It's either release or nothing. It's because now we have a process to push each commit to child repsitory.
@netlify
Copy link

netlify bot commented Mar 22, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit aab519c
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/623af27b62572600097de3b6
@shortcuts
Copy link
Member

shortcuts commented Mar 22, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the generated/main branch.

@eunjae-lee eunjae-lee marked this pull request as ready for review March 23, 2022 09:40
@eunjae-lee eunjae-lee requested review from millotp and shortcuts March 23, 2022 09:42
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this option not needed anymore ?

@shortcuts
Copy link
Member

Is this option not needed anymore ?

Context here @millotp

#276 (comment)

await run(`git push --tags`, { cwd: tempGitDir });
}
await execa('git', ['tag', `v${next}`], { cwd: tempGitDir });
await run(`git push --tags`, { cwd: tempGitDir });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a pro of git tags at all, but it seems weird to have git push twice, and --tags should be avoided according to this

Copy link
Contributor Author

@eunjae-lee eunjae-lee Mar 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I didn't know that option. aab519c

@eunjae-lee eunjae-lee enabled auto-merge (squash) March 23, 2022 10:21
@eunjae-lee eunjae-lee merged commit 7c07d99 into main Mar 23, 2022
@eunjae-lee eunjae-lee deleted the chore/no-update branch March 23, 2022 10:27
shortcuts pushed a commit that referenced this pull request Apr 22, 2022
* chore(ci): remove the option to just update repository * chore: remove temporary test condition * chore: push once
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants