feat(javascript): add addUserAgent method #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This was referenced Feb 23, 2022
This was referenced Feb 28, 2022
This was referenced Mar 22, 2022
shortcuts added a commit that referenced this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-333
This method is used by our other products (IS, Crawler, etc.) to provide their own User Agent.
Changes included:
addUserAgentmethod, that append to the current client User Agent.Unrelated changes:
A PR was not worth those small changes
privatefrompackagefieldsQuestions
Looking at the current clients behavior, I feel like this method is really specific to the JavaScript client. Do we want to provide API specific tests later?
🧪 Test
CI :D