Skip to content

Conversation

@eunjae-lee
Copy link
Contributor

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-314

Changes included:

  • Add jest to scripts package
  • Add some tests for getMarkdownSection function

🧪 Test

  • CI
@eunjae-lee
Copy link
Contributor Author

waiting for #147 to be merged (otherwise, CI won't pass)

@eunjae-lee eunjae-lee changed the title test(scripts): add jest for scripts package test(script): add jest for scripts package Feb 21, 2022
@eunjae-lee eunjae-lee requested a review from shortcuts February 21, 2022 14:04
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it make sense to add tests for those scripts, but we should check it in our CI

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :D

@eunjae-lee eunjae-lee enabled auto-merge (squash) February 21, 2022 15:02
@eunjae-lee eunjae-lee merged commit 1fa88dc into main Feb 21, 2022
@eunjae-lee eunjae-lee deleted the test/scripts branch February 21, 2022 15:04
shortcuts pushed a commit that referenced this pull request Apr 22, 2022
* test(scripts): add jest for scripts package * chore: update jest config * chore(ci): run test on CI * chore(ci): run test after setup job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants