feat(ci): build JavaScript client utils #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
shortcuts force-pushed the feat/ci-build-js-common branch from 64aa249 to 728bcda Compare 
shortcuts commented Feb 15, 2022
| if: steps.cache.outputs.cache-hit != 'true' | ||
| run: yarn build:clients javascript ${{ matrix.client.name }} | ||
| | ||
| client_javascript_common: |
There was a problem hiding this comment.
We should be able to group jobs after #135
shortcuts changed the title 
shortcuts added a commit that referenced this pull request Apr 22, 2022
This was referenced May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-311
Changes included:
We don't build the JavaScript utils folders (
client-common,requester-browser-xhr,requester-node-http) when restoring generated clients from cache, which can lead to outdated build.Motivations
Cache hit on #135 for utils folders, while they should've been rebuilt due to changes.
🧪 Test
CI :D