Skip to content

Modal flickering for some decimal widths #1767

@amckean-tbox

Description

@amckean-tbox

🐛 Bug Report

When sizing a modal based on screenSize like this

const width = screenSize * 0.56 

Note: this is also an issue for height

If the resulting number is a decimal number the modal can flicker from the right and after a minute or two leads to an object property storage error in metro, or app crash in production.

To Reproduce

Steps to reproduce the behavior:
Set modalWidth to 225.28 to show error

Expected behavior

Expect modal not to flicker, perhaps to handle this case internally?
Wrapping the offending number or calc in Math.round() fixes this.

Link to runnable example or repository (highly encouraged)

https://snack.expo.dev/v95Tv2-QT

UI Kitten and Eva version

Package Version
@eva-design/eva 2.1.1
@ui-kitten/components 5.1.2

Environment information

 System: OS: macOS 13.0.1 CPU: (8) arm64 Apple M1 Pro Binaries: Node: 16.15.1 - ~/.nvm/versions/node/v16.15.1/bin/node Yarn: 1.22.19 - /opt/homebrew/bin/yarn npm: 8.11.0 - ~/.nvm/versions/node/v16.15.1/bin/npm Watchman: 2023.07.03.00 - /opt/homebrew/bin/watchman SDKs: iOS SDK: Platforms: DriverKit 22.4, iOS 16.4, macOS 13.3, tvOS 16.4, watchOS 9.4 IDEs: Android Studio: 2022.1 AI-221.6008.13.2211.9477386 Xcode: 14.3.1/14E300c - /usr/bin/xcodebuild npmPackages: react: 18.1.0 => 18.1.0 react-native: 0.70.6 => 0.70.6 

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions