Skip to content

Conversation

@grubberr
Copy link
Contributor

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets January 26, 2022 18:58 Inactive
@grubberr
Copy link
Contributor Author

/test connector=connectors/source-postgres

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 26, 2022 19:05 Inactive
@grubberr grubberr self-assigned this Jan 26, 2022
@grubberr
Copy link
Contributor Author

/test connector=connectors/source-postgres

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 26, 2022 19:31 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

/test connector=connectors/source-postgres

@grubberr grubberr temporarily deployed to more-secrets January 26, 2022 19:43 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 26, 2022 19:44 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

/test connector=connectors/source-postgres

@grubberr grubberr temporarily deployed to more-secrets January 26, 2022 19:47 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 26, 2022 19:48 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets January 26, 2022 19:51 Inactive
@grubberr
Copy link
Contributor Author

/test connector=connectors/source-postgres

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 26, 2022 19:53 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

/test connector=connectors/source-postgres

@grubberr grubberr temporarily deployed to more-secrets January 26, 2022 19:59 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 26, 2022 20:00 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

/test connector=connectors/source-postgres

@grubberr grubberr temporarily deployed to more-secrets January 26, 2022 20:08 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 26, 2022 20:09 Inactive
@CLAassistant
Copy link

CLAassistant commented May 5, 2022

CLA assistant check
All committers have signed the CLA.

@grubberr
Copy link
Contributor Author

grubberr commented Jun 8, 2022

/test connector=connectors/source-postgres

1 similar comment
@grubberr
Copy link
Contributor Author

grubberr commented Jun 8, 2022

/test connector=connectors/source-postgres

grubberr added 2 commits June 8, 2022 18:07
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Jun 8, 2022

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2462482627

@grubberr grubberr temporarily deployed to more-secrets June 8, 2022 15:12 Inactive
@grubberr grubberr temporarily deployed to more-secrets June 8, 2022 15:23 Inactive
grubberr added 2 commits June 8, 2022 20:51
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Jun 8, 2022

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2463389161

@grubberr grubberr temporarily deployed to more-secrets June 8, 2022 17:55 Inactive
@grubberr grubberr temporarily deployed to more-secrets June 8, 2022 18:01 Inactive
grubberr added 2 commits June 9, 2022 08:07
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@9a4582a). Click here to learn what that means.
The diff coverage is n/a.

@@ Coverage Diff @@ ## master #9819 +/- ## ========================================= Coverage ? 92.05% ========================================= Files ? 4 Lines ? 680 Branches ? 0 ========================================= Hits ? 626 Misses ? 54 Partials ? 0 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a4582a...1c4d17a. Read the comment docs.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets June 9, 2022 07:01 Inactive
@grubberr grubberr temporarily deployed to more-secrets June 9, 2022 07:02 Inactive
@sherifnada sherifnada closed this Nov 23, 2022
@grubberr grubberr deleted the grubberr/get_gcp_gsm branch November 27, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 participants