Facebook marketing: Fix videos stream invalid type on jsonschema #9138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actions bot added area/connectors Contributor Author
| /test connector=connectors/source-facebook-marketing
|
Contributor Author
| /test connector=connectors/source-facebook-marketing
|
avida commented Dec 28, 2021
| assert is_specific_deleted_pulled, f"{stream_name} stream should have a deleted record with id={deleted_id}" | ||
| | ||
| @pytest.mark.parametrize("stream_name, deleted_num", [("ads", 2), ("campaigns", 3), ("ad_sets", 1)]) | ||
| @pytest.mark.parametrize("stream_name, deleted_num", [("ads", 2), ("campaigns", 1), ("ad_sets", 1)]) |
Contributor Author
There was a problem hiding this comment.
Not sure if it was correct to update number of deleted campaigns. Could it be related to start_date parameter change in the config or this is a bug @keu ?
yevhenii-ldv approved these changes Dec 28, 2021
Contributor
yevhenii-ldv left a comment
yevhenii-ldv left a comment There was a problem hiding this comment.
LGTM, in general! Except, not sure if the tests need to be updated. Why could they break?
| sourceDefinitionId: e7778cfc-e97c-4458-9ecb-b4f2bba8946c | ||
| dockerRepository: airbyte/source-facebook-marketing | ||
| dockerImageTag: 0.2.30 | ||
| dockerImageTag: 0.2.31 |
Contributor
There was a problem hiding this comment.
This parameter should be changed after publishing, because pipeline crashes
Contributor Author
| /publish connector=connectors/source-facebook-marketing
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Resolves #8975