Skip to content

Conversation

@igrankova
Copy link
Contributor

What

Add title and description properties to each field in source-connectors specifications:
source-pinterest

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@igrankova igrankova self-assigned this Dec 22, 2021
@github-actions github-actions bot added the area/connectors Connector related issues label Dec 22, 2021
@igrankova igrankova temporarily deployed to more-secrets December 22, 2021 14:22 Inactive
@igrankova igrankova linked an issue Dec 22, 2021 that may be closed by this pull request
@igrankova igrankova temporarily deployed to more-secrets December 22, 2021 14:26 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Dec 22, 2021
@igrankova
Copy link
Contributor Author

igrankova commented Dec 22, 2021

/test connector=connectors/source-pinterest

🕑 connectors/source-pinterest https://github.com/airbytehq/airbyte/actions/runs/1611717309
❌ connectors/source-pinterest https://github.com/airbytehq/airbyte/actions/runs/1611717309
🐛 https://gradle.com/s/kxohr4qtikgt6

@igrankova igrankova temporarily deployed to more-secrets December 22, 2021 14:28 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 22, 2021 14:30 Inactive
@annalvova05 annalvova05 self-requested a review December 28, 2021 08:56
@annalvova05 annalvova05 temporarily deployed to more-secrets December 28, 2021 08:58 Inactive
@annalvova05
Copy link
Contributor

annalvova05 commented Dec 28, 2021

/test connector=connectors/source-pinterest

🕑 connectors/source-pinterest https://github.com/airbytehq/airbyte/actions/runs/1630878225
✅ connectors/source-pinterest https://github.com/airbytehq/airbyte/actions/runs/1630878225
Python tests coverage:

 ---------- coverage: platform linux, python 3.8.10-final-0 ----------- Name Stmts Miss Cover -------------------------------------------------- source_pinterest/__init__.py 2 0 100% source_pinterest/source.py 175 36 79% source_pinterest/utils.py 4 0 100% -------------------------------------------------- TOTAL 181 36 80% ---------- coverage: platform linux, python 3.8.10-final-0 ----------- Name Stmts Miss Cover ------------------------------------------------------------------------ source_acceptance_test/__init__.py 2 0 100% source_acceptance_test/base.py 10 4 60% source_acceptance_test/config.py 74 6 92% source_acceptance_test/conftest.py 109 109 0% source_acceptance_test/plugin.py 47 47 0% source_acceptance_test/tests/__init__.py 4 0 100% source_acceptance_test/tests/test_core.py 242 96 60% source_acceptance_test/tests/test_full_refresh.py 38 0 100% source_acceptance_test/tests/test_incremental.py 69 38 45% source_acceptance_test/utils/__init__.py 6 0 100% source_acceptance_test/utils/asserts.py 37 2 95% source_acceptance_test/utils/common.py 54 17 69% source_acceptance_test/utils/compare.py 62 23 63% source_acceptance_test/utils/connector_runner.py 110 48 56% source_acceptance_test/utils/json_schema_helper.py 115 14 88% ------------------------------------------------------------------------ TOTAL 979 404 59% 

Python short test summary info:

=========================== short test summary info ============================ SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/tests/test_incremental.py:21: `future_state_path` not specified, skipping ================== 15 passed, 1 skipped in 118.51s (0:01:58) =================== 
@annalvova05 annalvova05 temporarily deployed to more-secrets December 28, 2021 14:54 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 28, 2021 14:55 Inactive
@annalvova05
Copy link
Contributor

annalvova05 commented Dec 28, 2021

/publish connector=connectors/source-pinterest

🕑 connectors/source-pinterest https://github.com/airbytehq/airbyte/actions/runs/1630908025
✅ connectors/source-pinterest https://github.com/airbytehq/airbyte/actions/runs/1630908025

@jrhizor jrhizor temporarily deployed to more-secrets December 28, 2021 15:05 Inactive
@annalvova05 annalvova05 merged commit 04704ff into master Dec 28, 2021
@annalvova05 annalvova05 deleted the igrankova/issue-8913-update-title-description branch December 28, 2021 15:26
@annalvova05 annalvova05 temporarily deployed to more-secrets December 28, 2021 15:26 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation

4 participants