- Notifications
You must be signed in to change notification settings - Fork 4.9k
🎉 New Source: Flexport #8777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 New Source: Flexport #8777
Conversation
| Thanks for the contribution @monai. Please change from draft to ready to review when the code is finished! |
| Hi @monai, I'm not sure if I answered exactly the question you asked. |
| @alafanechere the PR is ready for review. |
alafanechere left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @monai again for this clean contribution. I made some minor suggestions.
Can I also ask you to create a UUID for your source and create a file for it in .airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/, you can check other connector's file for example. We'd also need you to add your connector in airbyte-config/init/src/main/resources/seed/source_definitions.yaml.
As discussed on slack we're waiting to have a Flexport sandbox account to run this in our CI.
airbyte-integrations/connectors/source-flexport/source_flexport/source.py Show resolved Hide resolved
airbyte-integrations/connectors/source-flexport/source_flexport/source.py Show resolved Hide resolved
airbyte-integrations/connectors/source-flexport/source_flexport/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-flexport/source_flexport/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-flexport/source_flexport/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-flexport/source_flexport/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-flexport/source_flexport/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-flexport/source_flexport/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-flexport/source_flexport/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-flexport/unit_tests/test_streams.py Show resolved Hide resolved
| @alafanechere I've addressed your last comment in 0f45987. The PR is ready for review again. |
alafanechere left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @monai for these changes. Could you please provide a screenshot of the acceptance test passing? We do not yet have a Flexport sandbox account that could allow us to run these on our side. It's why I labeled the PR as waiting-for-credentials.
Acceptance tests |
| @monai Flexport remains silent about the creation of a sandbox account for Airbyte. I suggest we merge the connector and not publish it. It will allow users to build the connector themselves and still have this connector in our repo, we'll publish it eventually if Flexport replies to our sandbox request. |
I agree. |
alafanechere left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge without publishing as we miss a Flexport sandbox account.
| @alafanechere We can't add a connector to |
| @alafanechere how's the communication with Flexport? Any progress? |
| @monai, no reply from their side... |
What
This PR adds initial support for Flexport API. For now, it provides the following streams:
Recommended reading order
source.pyPre-merge Checklist
Unit tests
Acceptance tests
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/SUMMARY.mddocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampledocs/integrations/README.mdairbyte-integrations/builds.mdAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described hereThis change is