fix typeform authenticator loop #8466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
|
|
marcosmarxm suggested changes Dec 2, 2021
airbyte-integrations/connectors/source-typeform/source_typeform/source.py Outdated Show resolved Hide resolved
…m/source.py Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
airbyte-integrations/connectors/source-typeform/source_typeform/source.py Show resolved Hide resolved
marcosmarxm suggested changes Dec 2, 2021
Contributor
marcosmarxm left a comment
marcosmarxm left a comment There was a problem hiding this comment.
small comments, almost done 👍
airbyte-integrations/connectors/source-typeform/source_typeform/source.py Show resolved Hide resolved
airbyte-integrations/connectors/source-typeform/source_typeform/source.py Outdated Show resolved Hide resolved
brebuanirello-equinix force-pushed the 8410-fix-typeform-authenticator-loop branch from a950590 to 42ce878 Compare 
Contributor Author
| remaked to include empty form list |
marcosmarxm reviewed Dec 6, 2021
airbyte-integrations/connectors/source-typeform/source_typeform/source.py Outdated Show resolved Hide resolved
marcosmarxm suggested changes Dec 6, 2021
Contributor
marcosmarxm left a comment
marcosmarxm left a comment There was a problem hiding this comment.
small change, after that we can merge bump the connector version and publish it.
marcosmarxm approved these changes Dec 7, 2021
Contributor
marcosmarxm left a comment
marcosmarxm left a comment There was a problem hiding this comment.
thanks @bruno-nirello
github-actions bot added area/documentation 
marcosmarxm force-pushed the 8410-fix-typeform-authenticator-loop branch from f01750e to ae2d662 Compare github-actions bot removed area/server area/frontend CDK 
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
) * removed full forms list loop * better exception return * Update airbyte-integrations/connectors/source-typeform/source_typeform/source.py Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> * added comments to show bug * better error handling with empty form list * rebase Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> Co-authored-by: Marcos Marx <marcosmarxm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What
Our connection with typeform doesn't work with the current version 0.1.2, the method used to check connection is not improved for large accounts because make a full refresh and then after check if the form_id exists.
issue related:
#8410
How
Removing the loop in the full refresh forms, because the API does not respond.
Pre-merge Checklist
community Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described here