Skip to content

Conversation

@grubberr
Copy link
Contributor

@grubberr grubberr commented Nov 30, 2021

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

boards stream has to emit only records for configured board_ids.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? If yes, please make sure to include it here and in any changelogs with the 🚨🚨 emoji
What is the end result perceived by the user?

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@github-actions github-actions bot added the area/connectors Connector related issues label Nov 30, 2021
@grubberr grubberr temporarily deployed to more-secrets November 30, 2021 14:31 Inactive
@grubberr grubberr self-assigned this Nov 30, 2021
@grubberr grubberr linked an issue Nov 30, 2021 that may be closed by this pull request
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets November 30, 2021 15:09 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets November 30, 2021 16:35 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets November 30, 2021 18:21 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Nov 30, 2021

/test connector=connectors/source-trello

🕑 connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/1522335009
✅ connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/1522335009
Python tests coverage:

 ---------- coverage: platform linux, python 3.8.10-final-0 ----------- Name Stmts Miss Cover ------------------------------------------------------------------------ source_acceptance_test/__init__.py 2 0 100% source_acceptance_test/base.py 10 4 60% source_acceptance_test/config.py 75 8 89% source_acceptance_test/conftest.py 108 108 0% source_acceptance_test/plugin.py 47 47 0% source_acceptance_test/tests/__init__.py 4 0 100% source_acceptance_test/tests/test_core.py 200 94 53% source_acceptance_test/tests/test_full_refresh.py 38 27 29% source_acceptance_test/tests/test_incremental.py 69 38 45% source_acceptance_test/utils/__init__.py 6 0 100% source_acceptance_test/utils/asserts.py 37 2 95% source_acceptance_test/utils/common.py 41 24 41% source_acceptance_test/utils/compare.py 62 25 60% source_acceptance_test/utils/connector_runner.py 82 49 40% source_acceptance_test/utils/json_schema_helper.py 115 14 88% ------------------------------------------------------------------------ TOTAL 896 440 51% ---------- coverage: platform linux, python 3.8.10-final-0 ----------- Name Stmts Miss Cover ----------------------------------------------- source_trello/__init__.py 2 0 100% source_trello/source.py 114 31 73% source_trello/utils.py 28 1 96% ----------------------------------------------- TOTAL 144 32 78% 
@grubberr grubberr temporarily deployed to more-secrets November 30, 2021 18:25 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 30, 2021 18:26 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets November 30, 2021 20:14 Inactive
@grubberr
Copy link
Contributor Author

grubberr commented Dec 1, 2021

/test connector=connectors/source-trello

🕑 connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/1525156342
✅ connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/1525156342
Python tests coverage:

 ---------- coverage: platform linux, python 3.8.10-final-0 ----------- Name Stmts Miss Cover ------------------------------------------------------------------------ source_acceptance_test/__init__.py 2 0 100% source_acceptance_test/base.py 10 4 60% source_acceptance_test/config.py 76 8 89% source_acceptance_test/conftest.py 108 108 0% source_acceptance_test/plugin.py 47 47 0% source_acceptance_test/tests/__init__.py 4 0 100% source_acceptance_test/tests/test_core.py 235 95 60% source_acceptance_test/tests/test_full_refresh.py 38 27 29% source_acceptance_test/tests/test_incremental.py 69 38 45% source_acceptance_test/utils/__init__.py 6 0 100% source_acceptance_test/utils/asserts.py 37 2 95% source_acceptance_test/utils/common.py 54 24 56% source_acceptance_test/utils/compare.py 62 25 60% source_acceptance_test/utils/connector_runner.py 82 49 40% source_acceptance_test/utils/json_schema_helper.py 115 14 88% ------------------------------------------------------------------------ TOTAL 945 441 53% ---------- coverage: platform linux, python 3.8.10-final-0 ----------- Name Stmts Miss Cover ----------------------------------------------- source_trello/__init__.py 2 0 100% source_trello/source.py 113 26 77% source_trello/utils.py 28 1 96% ----------------------------------------------- TOTAL 143 27 81% 
@grubberr grubberr temporarily deployed to more-secrets December 1, 2021 09:50 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 1, 2021 09:52 Inactive
@grubberr grubberr requested a review from antixar December 1, 2021 10:03
Copy link
Contributor

@danieldiamond danieldiamond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Please publish your fix.

@grubberr
Copy link
Contributor Author

grubberr commented Dec 1, 2021

/publish connector=connectors/source-trello

🕑 connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/1525914572
✅ connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/1525914572

@jrhizor jrhizor temporarily deployed to more-secrets December 1, 2021 13:13 Inactive
@grubberr grubberr temporarily deployed to more-secrets December 1, 2021 14:31 Inactive
@grubberr grubberr merged commit 15fe4dd into master Dec 1, 2021
@grubberr grubberr deleted the grubberr/8326-source-trello branch December 1, 2021 14:31
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* 'Boards' stream returns only specific (board_ids) records * github secret -> google secret Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues

6 participants