Skip to content

Conversation

@monai
Copy link
Contributor

@monai monai commented Nov 22, 2021

What

This PR adds stream ProcessedOrderDetails utilising HttpSubStream, a substream of ProcessedOrders.

Recommended reading order

  1. streams.py

Pre-merge Checklist

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
@github-actions github-actions bot added the area/connectors Connector related issues label Nov 22, 2021
@harshithmullapudi
Copy link
Contributor

Hey @monai thanks for contribution. Can you move the PR out of draft state when you are ready.

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Nov 23, 2021
@monai monai marked this pull request as ready for review November 23, 2021 14:45
@alafanechere alafanechere self-assigned this Nov 23, 2021
Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this stream addition! I'll open a side branch to run our CI, I confirm that tests are passing on my machine.

@alafanechere alafanechere temporarily deployed to more-secrets November 23, 2021 16:58 Inactive
@alafanechere alafanechere merged commit 0b80318 into airbytehq:master Nov 23, 2021
@monai monai deleted the linnworks-pod branch November 24, 2021 07:27
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation community

4 participants