Remove base-python gradle dependencies in connectors where base-python is not used #7499

htrueman · 2021-10-29T19:12:07Z

What

Part of #7242 story.

How

Updated connectors with base-python, but where base-python is not used.

Removed base-python references.
Removed requirements.txt.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Community member? Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- docs/SUMMARY.md
- docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
- docs/integrations/README.md
- airbyte-integrations/builds.md
PR name follows PR naming conventions
Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions
Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

…dk' into htrueman/remove-base-python-gradle-dependencies

…factor-to-cdk' into htrueman/remove-base-python-gradle-dependencies

…ctor-to-cdk' into htrueman/remove-base-python-gradle-dependencies

…-cdk' into htrueman/remove-base-python-gradle-dependencies

…efactor-to-cdk' into htrueman/remove-base-python-gradle-dependencies

Remove requirements.txt files.

CLAassistant · 2021-10-29T19:12:13Z

All committers have signed the CLA.

…e-python-gradle-dependencies

htrueman · 2021-11-09T20:43:19Z

/publish connector=connectors/source-shortio

🕑 connectors/source-shortio https://github.com/airbytehq/airbyte/actions/runs/1441321219
✅ connectors/source-shortio https://github.com/airbytehq/airbyte/actions/runs/1441321219

htrueman · 2021-11-09T21:34:58Z

/publish connector=connectors/source-square

🕑 connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1441498697
❌ connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1441498697
🕑 connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1441498697
❌ connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1441498697
🕑 connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1441498697
✅ connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1441498697

htrueman · 2021-11-09T21:35:30Z

/publish connector=connectors/source-us-census

🕑 connectors/source-us-census https://github.com/airbytehq/airbyte/actions/runs/1441500484
✅ connectors/source-us-census https://github.com/airbytehq/airbyte/actions/runs/1441500484

htrueman · 2021-11-09T21:35:44Z

/publish connector=connectors/source-snapchat-marketing

🕑 connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/1441501021
✅ connectors/source-snapchat-marketing https://github.com/airbytehq/airbyte/actions/runs/1441501021

…e-python-gradle-dependencies # Conflicts: # airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/12928b32-bf0a-4f1e-964f-07e12e37153a.json # airbyte-config/init/src/main/resources/seed/source_definitions.yaml # airbyte-integrations/connectors/source-intercom/Dockerfile # airbyte-integrations/connectors/source-mixpanel/Dockerfile # docs/integrations/sources/intercom.md # docs/integrations/sources/mixpanel.md

…n is not used (airbytehq#7499) * Remeve base-python references. * Add requirements.txt * Fix requirements.txt blank line * Fix source-exchange rates to common CDK approach * Fix source-smartsheets SAT. Fix source-exchange-rates build.gradle. * Bump docker version * Update source-dixa SAT config * Fix source-exchange-rates SAT config * Revert bump scaffold sources version * Fix source-shortio SAT config * Fix source-square invalid_config.json * Fix source-us-census invalid_config.json * Fix source-intercom versioning

htrueman added 13 commits October 27, 2021 18:41

Remeve base-python references.

468df3f

Remove base-python references

55e77d2

Add requirements.txt

89382f1

Add requirements.txt

d9c5aeb

Remove base-python references

ae93470

Remove base-python references

351a94c

Remove base-python references

5accbce

Merge remote-tracking branch 'origin/htrueman/source-s3-refactor-to-c…

c534c97

…dk' into htrueman/remove-base-python-gradle-dependencies

Merge remote-tracking branch 'origin/htrueman/source-apify-dataset-re…

a190b3b

…factor-to-cdk' into htrueman/remove-base-python-gradle-dependencies

Merge remote-tracking branch 'origin/htrueman/source-bigcommerce-refa…

89bcbdd

…ctor-to-cdk' into htrueman/remove-base-python-gradle-dependencies

Merge remote-tracking branch 'origin/htrueman/source-dixa-refactor-to…

ae231ab

…-cdk' into htrueman/remove-base-python-gradle-dependencies

Merge remote-tracking branch 'origin/htrueman/source-exchange-rates-r…

475cb4e

…efactor-to-cdk' into htrueman/remove-base-python-gradle-dependencies

Remove base-python references.

e7ac7b0

Remove requirements.txt files.

htrueman requested review from Zirochkaa, avida and yevhenii-ldv October 29, 2021 19:12

github-actions bot added the area/connectors Connector related issues label Oct 29, 2021

htrueman self-assigned this Oct 29, 2021

htrueman changed the title ~~Htrueman/remove base python gradle dependencies~~ Remove base-python gradle dependencies in connectors where base-python is not used Oct 29, 2021

htrueman mentioned this pull request Nov 1, 2021

[Story] Completely update all base-python connectors, use CDK package instead #7242

Closed

36 tasks

htrueman added 5 commits November 1, 2021 19:54

Get back requirements.txt files

ba5af00

Delete s.sh

b1728de

Merge remote-tracking branch 'origin/master' into htrueman/remove-bas…

16907ca

…e-python-gradle-dependencies

Fix requirements.txt blank line

5172b2c

Fix source-exchange rates to common CDK approach

df5f0c8

github-actions bot added the area/documentation Improvements or additions to documentation label Nov 1, 2021

htrueman temporarily deployed to more-secrets November 1, 2021 20:15 Inactive

jrhizor temporarily deployed to more-secrets November 2, 2021 07:44 Inactive

htrueman temporarily deployed to more-secrets November 9, 2021 20:05 Inactive

Fix source-shortion SAT config

aac77b7

htrueman temporarily deployed to more-secrets November 9, 2021 20:44 Inactive

jrhizor temporarily deployed to more-secrets November 9, 2021 20:45 Inactive

jrhizor temporarily deployed to more-secrets November 9, 2021 20:53 Inactive

htrueman added 2 commits November 9, 2021 23:04

Fix source-square invalid_config.json

65a78cd

Fix source-us-census invalid_config.json

57b52d5

htrueman temporarily deployed to more-secrets November 9, 2021 21:36 Inactive

jrhizor temporarily deployed to more-secrets November 9, 2021 21:37 Inactive

jrhizor temporarily deployed to more-secrets November 9, 2021 21:48 Inactive

jrhizor temporarily deployed to more-secrets November 9, 2021 21:59 Inactive

htrueman added 2 commits November 10, 2021 12:39

Fix source-intercom versioning

2ed2f36

htrueman temporarily deployed to more-secrets November 10, 2021 10:57 Inactive

jrhizor temporarily deployed to more-secrets November 10, 2021 10:58 Inactive

htrueman merged commit 504580d into master Nov 10, 2021

htrueman deleted the htrueman/remove-base-python-gradle-dependencies branch November 10, 2021 11:12

jrhizor mentioned this pull request Nov 11, 2021

Bump Airbyte version from 0.30.38-alpha to 0.30.39-alpha #7860

Merged

igrankova added connectors/sources-api connectors/source/apify-dataset labels Jan 4, 2022

karinakuz added connectors/source/dixa int/singer-exchange-rates-api-source labels Jan 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove base-python gradle dependencies in connectors where base-python is not used #7499

Remove base-python gradle dependencies in connectors where base-python is not used #7499

Uh oh!

htrueman commented Oct 29, 2021 •

edited

Loading

CLAassistant commented Oct 29, 2021 •

edited

Loading

htrueman commented Nov 9, 2021 •

edited by github-actions bot

Loading

htrueman commented Nov 9, 2021 •

edited by github-actions bot

Loading

htrueman commented Nov 9, 2021 •

edited by github-actions bot

Loading

htrueman commented Nov 9, 2021 •

edited by github-actions bot

Loading

Labels

9 participants

Remove base-python gradle dependencies in connectors where base-python is not used #7499

Remove base-python gradle dependencies in connectors where base-python is not used #7499

Uh oh!

Conversation

htrueman commented Oct 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

How

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

CLAassistant commented Oct 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

htrueman commented Nov 9, 2021 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

htrueman commented Nov 9, 2021 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

htrueman commented Nov 9, 2021 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

htrueman commented Nov 9, 2021 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Labels

9 participants

htrueman commented Oct 29, 2021 •

edited

Loading

CLAassistant commented Oct 29, 2021 •

edited

Loading

htrueman commented Nov 9, 2021 •

edited by github-actions bot

Loading

htrueman commented Nov 9, 2021 •

edited by github-actions bot

Loading

htrueman commented Nov 9, 2021 •

edited by github-actions bot

Loading

htrueman commented Nov 9, 2021 •

edited by github-actions bot

Loading