[source-hubspot] - migrate deals_pipelinesto low code #59195
Conversation
| The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| $ref: "#/definitions/base_retriever" | ||
| requester: | ||
| $ref: "#/definitions/base_requester" | ||
| path: /crm-pipelines/v1/pipelines/deals |
There was a problem hiding this comment.
Note that I've maintained use of the v1 endpoint for this migration, but we should probably update to v3 at some point. There will be some annoyances (i.e. many transformations) involved with that.
There was a problem hiding this comment.
yep for simplicity and no strict deprecation date, we can leave as is to make the migration easier
brianjlai left a comment
brianjlai left a comment There was a problem hiding this comment.
overall looks good, just a few notes and comments. Given that this is quite similar to many of our other client-side incremental streams, I think we can just rely on our regression testing result analysis and skip the progressive rollout. Once we have that and the comments then 👍
| $ref: "#/definitions/base_retriever" | ||
| requester: | ||
| $ref: "#/definitions/base_requester" | ||
| path: /crm-pipelines/v1/pipelines/deals |
There was a problem hiding this comment.
yep for simplicity and no strict deprecation date, we can leave as is to make the migration easier
airbyte-integrations/connectors/source-hubspot/source_hubspot/source.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-hubspot/source_hubspot/manifest.yaml Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-hubspot/source_hubspot/manifest.yaml Outdated Show resolved Hide resolved
| max_concurrency: 40 | ||
| | ||
| schemas: | ||
| deal_pipelines: |
There was a problem hiding this comment.
we should also delete the schemas/deal_pipelines.json since its now inline
airbyte-integrations/connectors/source-hubspot/source_hubspot/manifest.yaml Outdated Show resolved Hide resolved
|
What
deal_pipelinesto low-codeHow
is_client_side_incremental = trueReview guide
manifest.yamlCan this PR be safely reverted and rolled back?