Skip to content

Conversation

@bazarnov
Copy link
Contributor

@bazarnov bazarnov commented Sep 5, 2021

What

#5852 - Source Shopify: incorrect type of amount in order_refunds schema

How

  • edited the order_refunds schema
  • extended timeout_seconds in acceptance-test-config.yml for future enhancements.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Documentation updated
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Depends on:

  • - SAT: cannot handle None/null with format date-time 5854
@github-actions github-actions bot added the area/connectors Connector related issues label Sep 5, 2021
@bazarnov bazarnov changed the title 🐛 🐛 Source Shopify: fix for incorrect amount type in order_refunds schema Sep 5, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Sep 5, 2021
@bazarnov bazarnov linked an issue Sep 5, 2021 that may be closed by this pull request
@bazarnov bazarnov self-assigned this Sep 5, 2021
@bazarnov
Copy link
Contributor Author

bazarnov commented Sep 5, 2021

#TODO:

Run /test connector=connectors/source-shopify after #5854 is fixed.

@bazarnov
Copy link
Contributor Author

bazarnov commented Sep 6, 2021

/test connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1205162566
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1205162566

@jrhizor jrhizor temporarily deployed to more-secrets September 6, 2021 08:00 Inactive
@bazarnov bazarnov requested review from antixar and lazebnyi September 6, 2021 08:17
@bazarnov
Copy link
Contributor Author

bazarnov commented Sep 6, 2021

/publish connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1205387572
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1205387572

@jrhizor jrhizor temporarily deployed to more-secrets September 6, 2021 09:12 Inactive
@bazarnov bazarnov merged commit 1861fb0 into master Sep 6, 2021
@bazarnov bazarnov deleted the bazarnov/shopify-sat-test-fix branch September 6, 2021 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation

5 participants