✨feat(source-sftp-bulk): adjust file record message protocol #57514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aldogonzalez8 changed the title 2 tasks
bazarnov approved these changes Apr 23, 2025
| | ||
| @pytest.mark.slow | ||
| @pytest.mark.limit_memory("10 MB") | ||
| @pytest.mark.limit_memory("11 MB") |
Contributor
There was a problem hiding this comment.
Is there a reason we changed the size here?
Contributor Author
There was a problem hiding this comment.
After play for a few minutes with this locally, I also got a consistent message (not increasing) in the master branch as in the dev branch:
Test was limited to 10.0MiB but allocated 10.6MiB
So, it's more a matter of local memory resources than an issue with the changes. Then, it's safe to increase this to avoid annoying the local developer.
…-record-message-protocol
…-record-message-protocol
aldogonzalez8 deleted the aldogonzalez8/source-sftp-bulk/adjust-file-record-message-protocol branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What
This PR updates the
source-sftp-bulkconnector to comply with the latest file transfer record protocol.Resolves: https://github.com/airbytehq/airbyte-internal-issues/issues/12342
How
source-sftp-bulk: connector's implementation to align with the latest protocol specifications.Review guide
1.
airbyte-integrations/connectors/source-sftp-bulk/source_sftp_bulk/stream_reader.py: returns file reference and file metadata.User Impact
Can this PR be safely reverted and rolled back?