Skip to content

🐛 Source Slack: Fix max retries issue #5697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 31, 2021
Merged

🐛 Source Slack: Fix max retries issue #5697

merged 6 commits into from
Aug 31, 2021

Conversation

@lazebnyi
Copy link
Contributor

@lazebnyi lazebnyi commented Aug 27, 2021 •
edited
Loading

What

#5184 - Slack as a source - unable to complete sync - goes into retry mode

How

Updated to default backoff

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.
@github-actions github-actions bot added the area/connectors Connector related issues label Aug 27, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Aug 27, 2021
@lazebnyi lazebnyi linked an issue Aug 27, 2021 that may be closed by this pull request
Slack as a source - unable to complete sync - goes into retry mode #5184
Closed
@lazebnyi lazebnyi requested review from antixar and removed request for midavadim August 27, 2021 09:35
@lazebnyi lazebnyi marked this pull request as ready for review August 30, 2021 12:30
@lazebnyi
Copy link
Contributor Author

lazebnyi commented Aug 30, 2021 •
edited
Loading

/test connector=connectors/source-slack

🕑 connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/1182150230
✅ connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/1182150230
@jrhizor jrhizor temporarily deployed to more-secrets August 30, 2021 12:33 Inactive
@lazebnyi
Copy link
Contributor Author

lazebnyi commented Aug 30, 2021 •
edited
Loading

/publish connector=connectors/source-slack

🕑 connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/1182174986
❌ connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/1182174986
@jrhizor jrhizor temporarily deployed to more-secrets August 30, 2021 12:42 Inactive
@lazebnyi
Copy link
Contributor Author

lazebnyi commented Aug 30, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-slack

🕑 connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/1182192245
❌ connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/1182192245
@jrhizor jrhizor temporarily deployed to more-secrets August 30, 2021 12:47 Inactive
@lazebnyi
Copy link
Contributor Author

lazebnyi commented Aug 31, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-slack

🕑 connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/1185488903
✅ connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/1185488903
@jrhizor jrhizor temporarily deployed to more-secrets August 31, 2021 09:07 Inactive
@lazebnyi
Copy link
Contributor Author

lazebnyi commented Aug 31, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-slack

🕑 connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/1185768657
✅ connectors/source-slack https://github.com/airbytehq/airbyte/actions/runs/1185768657
@jrhizor jrhizor temporarily deployed to more-secrets August 31, 2021 10:36 Inactive
@lazebnyi lazebnyi merged commit ff70fd3 into master Aug 31, 2021
@lazebnyi lazebnyi deleted the lazebnyi/5184-slack-max-retries-issue branch August 31, 2021 10:43
@jrhizor jrhizor mentioned this pull request Sep 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation

5 participants

@lazebnyi @yaroslav-dudar @antixar @jrhizor