Destination MSSQL: move mssql stuff from load-object-storage into dest-mssql #55886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
frifriSF59 approved these changes Mar 20, 2025
Contributor
frifriSF59 left a comment
frifriSF59 left a comment There was a problem hiding this comment.
Makes sense to me.
I think keeping the destination specific code out is something we should aim for as much as possible
Valgard pushed a commit to mayflower/airbyte that referenced this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
no reason to leave MSSQL-specific code in the generic toolkit, I think?
(not sure if there's anything worth testing manually - i.e. if CI passes, presumably we're OK to merge?)