✨ Source Hubspot: add conversionId to form submissions schema #55245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @kyleromines is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
kyleromines had a problem deploying to community-ci-auto 
GitHub Actions Error kyleromines changed the title 
octavia-squidington-iii added the area/documentation kyleromines temporarily deployed to community-ci-auto GitHub Actions Inactive 
Contributor
| @marcosmarxm can you give this a round of reviews please? |
marcosmarxm had a problem deploying to community-ci-auto GitHub Actions Error marcosmarxm had a problem deploying to community-ci GitHub Actions Error marcosmarxm had a problem deploying to community-ci GitHub Actions Error marcosmarxm had a problem deploying to community-ci GitHub Actions Error marcosmarxm temporarily deployed to community-ci-auto GitHub Actions Inactive marcosmarxm had a problem deploying to community-ci GitHub Actions Error marcosmarxm temporarily deployed to community-ci GitHub Actions Inactive kyleromines temporarily deployed to community-ci-auto GitHub Actions Inactive kyleromines had a problem deploying to community-ci GitHub Actions Error kyleromines had a problem deploying to community-ci GitHub Actions Error kyleromines had a problem deploying to community-ci GitHub Actions Error kyleromines temporarily deployed to community-ci-auto GitHub Actions Inactive kyleromines had a problem deploying to community-ci GitHub Actions Error kyleromines had a problem deploying to community-ci GitHub Actions Error kyleromines temporarily deployed to community-ci-auto GitHub Actions Inactive kyleromines had a problem deploying to community-ci GitHub Actions Error kyleromines had a problem deploying to community-ci-auto GitHub Actions Error kyleromines had a problem deploying to community-ci GitHub Actions Error kyleromines had a problem deploying to community-ci GitHub Actions Error kyleromines had a problem deploying to community-ci-auto GitHub Actions Error kyleromines had a problem deploying to community-ci GitHub Actions Error kyleromines had a problem deploying to community-ci GitHub Actions Error kyleromines temporarily deployed to community-ci GitHub Actions Inactive kyleromines temporarily deployed to community-ci-auto GitHub Actions Inactive kyleromines temporarily deployed to community-ci GitHub Actions Inactive Contributor Author
| @marcosmarxm Hey marco I see some changes were pushed to master. Wanted to get this one merged too if possible. |
github-project-automation bot moved this from Ready to Ship to Done in 🧑🏭 Community Pull Requests Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What
Add conversionId to the forms submission schema. You can see this is included here: https://developers.hubspot.com/docs/reference/api/marketing/forms/v1#get-submissions-for-a-form. For us this ID is unique across form submissions so I gave it the description that it is the unique ID for the table.
How
Added json to schema json
Review guide
User Impact
Hubspot connector users will now get all fields association with form submissions
Can this PR be safely reverted and rolled back?