🐛 Source HubSpot: Fix empty string inside number / float datatype #5334
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What
#5293 - Source Hubspot fails in normalization step
How
field_valueverification for anempty stringtoapi.py, if so - set thefield_valueto be zero, instead of empty string.test_field_type_converting.pyunit-test to simulate the issue ofempty stringinsidenumeric (float)typeNOTE:
This fix potentially could resolve the issue with
Bad Double Valuewhen using this connector along withDestination BigQueryfor data replication. As far as BigQuery does not accept simplenullvalues, and could not accept empty strings as numeric values, it requires additional data preprocessing before inject the data into the table.Pre-merge Checklist
Updating a connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mddocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described here