fix(source-instagram): unhide oauth fields #53171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii added area/connectors 
bazarnov approved these changes Feb 4, 2025
| } | ||
| }, | ||
| "required": ["access_token"] | ||
| "required": ["client_id", "client_secret", "access_token"] |
Contributor
There was a problem hiding this comment.
This is the answer why optinal
Contributor Author
There was a problem hiding this comment.
Ah sorry what I meant was in instagram 3.14 I could see client_id and client_secret under optional. But in the original report client_id and client_secret were missing from the optional section.
Was not sure why
Contributor Author
There was a problem hiding this comment.
Oh nvm! Looks like it was an issue with an (unoticed) page refresh when I was developing!
bnchrch force-pushed the bnchrch/source-instagram/unhide-oauth-fields branch from b80b660 to e355629 Compare 
Contributor Author
| Currently trying to validate I can login with instagram / facebook and seem to be running into a scope issue Looks like this is a valid reason to bring your own access token in this case |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What
Fixes #53158
How
Unhides client id and client secret and makes them required