fix(source-intercom): incremental not emitting state #52132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii added area/connectors 
Contributor
| @lazebnyi can you take this one? |
darynaishchenko commented Jan 28, 2025
airbyte-integrations/connectors/source-intercom/integration_tests/abnormal_state.json Show resolved Hide resolved
tolik0 approved these changes Jan 28, 2025
Collaborator Author
| Regression test results: State count 0.9.0 vs dev: test_catalog_are_the_same[failed]full refresh streams are now not resumable, related on cdk update. Acceptable and expected. test_all_records_are_the_same_with_state[failed for when control 0.8.3, but passed when control is 0.9.0]Expected: on latest cdk version records don't have some fields when their value Null |
Collaborator Author
| /approve-regression-tests
|
stephane-airbyte pushed a commit that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What
https://github.com/airbytehq/oncall/issues/7302
cdk doesn’t emit state while reading records, because checkpoint_interval for declarative stream is None. And in the end of the read cdk also doesn’t emit state because new_state == previous_state.
How
fixed
get_stream_stateto return a copy of current state not ref to the state. updated to latest cdk with fix for checkpointingReview guide
User Impact
Can this PR be safely reverted and rolled back?