Skip to content

Conversation

@bkrausz
Copy link
Contributor

@bkrausz bkrausz commented Jul 30, 2021

The rate limit was accidentally set to 1000 requests per hour, whereas it actually should be 1000 requests per minute. We should really time the request and run based off of that, but this is a super quick order of magnitude improvement without having to refactor anything.

Pre-merge Checklist

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in the connector's spec
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Documentation updated
    • README.md
    • docs/SUMMARY.md if it's a new connector
    • Created or updated reference docs in docs/integrations/<source or destination>/<name>.
    • Changelog in the appropriate page in docs/integrations/.... See changelog example
    • docs/integrations/README.md contains a reference to the new connector
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified
The rate limit was accidentally set to 1000 requests per hour, whereas it actually should be 1000 requests per minute. We should really time the request and run based off of that, but this is a super quick order of magnitude improvement without having to refactor anything.
@github-actions github-actions bot added the area/connectors Connector related issues label Jul 30, 2021
@sherifnada sherifnada requested a review from lazebnyi August 1, 2021 19:04
@sherifnada
Copy link
Contributor

Thanks @bkrausz ! Will merge this v soon

@lazebnyi
Copy link
Contributor

lazebnyi commented Aug 2, 2021

Thanks, @bkrausz for your PR! Could you allow edits from maintainers for updating docs and versions before merging?

@bkrausz
Copy link
Contributor Author

bkrausz commented Aug 2, 2021

Thanks, @bkrausz for your PR! Could you allow edits from maintainers for updating docs and versions before merging?

Already enabled, thanks!

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Aug 2, 2021
@lazebnyi
Copy link
Contributor

lazebnyi commented Aug 2, 2021

/test connector=connectors/source-intercom

Error: No ref found for: patch-2

@lazebnyi
Copy link
Contributor

lazebnyi commented Aug 2, 2021

/test connector=connectors/source-intercom

🕑 connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/1091493061
✅ connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/1091493061

@lazebnyi
Copy link
Contributor

lazebnyi commented Aug 2, 2021

/publish connector=connectors/source-intercom

🕑 connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/1091517827
✅ connectors/source-intercom https://github.com/airbytehq/airbyte/actions/runs/1091517827

@lazebnyi lazebnyi merged commit cca9f69 into airbytehq:master Aug 2, 2021
@bkrausz bkrausz deleted the patch-2 branch August 13, 2021 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation

4 participants