Skip to content

🎉 Source Shopify - change the default stream cursor_field to 'updated_at' where possible #4472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 5, 2021
Merged

🎉 Source Shopify - change the default stream cursor_field to 'updated_at' where possible #4472

merged 13 commits into from
Jul 5, 2021

Conversation

@bazarnov
Copy link
Contributor

@bazarnov bazarnov commented Jul 1, 2021

What

#4346 - Source-Shopify migrate from since_id to datetime

How

  • changed the request_parameters in ShopifyStream class
  • changed the request_parameters in the IncrementalShopifyStream class
  • modified code for all stream classes
  • added state comparison to next classes: OrderRefunds, OrderRisks, Transactions, DiscountCodes to catch the latest records

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Unit & integration tests added as appropriate (and are passing)
    ./gradlew :airbyte-integrations:connectors:source-shopify:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
  • Code reviews completed
  • Documentation updated
    • Updated reference docs in docs/integrations/<source or destination>/<name>.
    • Changelog in the appropriate page in docs/integrations/.... See changelog example
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified
@bazarnov bazarnov self-assigned this Jul 1, 2021
@bazarnov bazarnov requested a review from midavadim July 1, 2021 20:11
@github-actions github-actions bot added the area/connectors Connector related issues label Jul 1, 2021
@bazarnov bazarnov requested a review from sherifnada July 1, 2021 20:11
@bazarnov bazarnov linked an issue Jul 1, 2021 that may be closed by this pull request
🎉 Source-Shopify migrate from since_id to datetime #4346
Closed
@bazarnov
Copy link
Contributor Author

bazarnov commented Jul 1, 2021

Migrated from previous pull request: #4416
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jul 1, 2021
Oleksandr Bazarnov added 2 commits July 2, 2021 00:09
midavadim
midavadim suggested changes Jul 4, 2021
View reviewed changes
sherifnada
sherifnada reviewed Jul 4, 2021
View reviewed changes
@bazarnov
Copy link
Contributor Author

bazarnov commented Jul 4, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/998996333
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/998996333
sherifnada
sherifnada approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments but should be good to go afterwards
@bazarnov
Copy link
Contributor Author

bazarnov commented Jul 5, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1000599261
❌ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1000599261
🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1000599261
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1000599261
@bazarnov
Copy link
Contributor Author

bazarnov commented Jul 5, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1000967315
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/1000967315
@bazarnov bazarnov merged commit 9517fae into master Jul 5, 2021
@bazarnov bazarnov deleted the bazarnov/4346-shopify-migrate-to-datimes branch July 5, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation

4 participants

@bazarnov @midavadim @sherifnada