Skip to content

Source launchdarkly: Migrate to manifest-only #44135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2024
Merged

Source launchdarkly: Migrate to manifest-only #44135

merged 1 commit into from
Aug 16, 2024

Conversation

@ChristoGrab
Copy link
Contributor

@ChristoGrab ChristoGrab commented Aug 15, 2024

What

Migrates source-launchdarkly to manifest-only format

How

Used a script to run the airbyte-ci commands [migrate-to-manifest-only, bump-version, format fix, pull-request]

Review Guide

  1. manifest.yaml: should be at the root level of the folder, list version 4.3.0, contain an inlined spec, and all $parameters should be resolved.
  2. metadata.py: should list the correct manifest-only language tag, have pypi disabled, and point to a recent version of source-declarative-manifest
  3. acceptance-test-config.yml: should correctly point to manifest.yaml for the spec test
  4. readme.md: Should be updated with correct references to the connector
  5. Pretty much everything else should be nuked

User Impact

None
@vercel
Copy link

vercel bot commented Aug 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 7:58pm
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Aug 15, 2024
@ChristoGrab ChristoGrab force-pushed the christo/launchdarkly-manifest-only branch from 622bc9a to e787e8d Compare August 15, 2024 19:49
@octavia-squidington-iv octavia-squidington-iv requested a review from a team August 15, 2024 19:50
@airbyteio airbyteio merged commit 3e96bf9 into master Aug 16, 2024
@airbyteio airbyteio deleted the christo/launchdarkly-manifest-only branch August 16, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation auto-merge connectors/source/launchdarkly

4 participants

@ChristoGrab @octavia-squidington-iii @airbyteio