Support Snowflake key pair auth for source connector #40424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
octavia-squidington-iii added area/connectors 
aharbunou-branch temporarily deployed to community-ci-auto 
GitHub Actions Inactive aharbunou-branch had a problem deploying to community-ci-auto GitHub Actions Failure aharbunou-branch had a problem deploying to community-ci GitHub Actions Error aharbunou-branch had a problem deploying to community-ci GitHub Actions Error aharbunou-branch changed the title aharbunou-branch had a problem deploying to community-ci GitHub Actions Error aharbunou-branch temporarily deployed to community-ci-auto GitHub Actions Inactive aharbunou-branch had a problem deploying to community-ci-auto GitHub Actions Failure aharbunou-branch had a problem deploying to community-ci GitHub Actions Error aharbunou-branch had a problem deploying to community-ci-auto GitHub Actions Failure aharbunou-branch temporarily deployed to community-ci-auto GitHub Actions Inactive aharbunou-branch had a problem deploying to community-ci GitHub Actions Error aharbunou-branch had a problem deploying to community-ci GitHub Actions Error aharbunou-branch temporarily deployed to community-ci-auto GitHub Actions Inactive aharbunou-branch temporarily deployed to community-ci-auto GitHub Actions Inactive aharbunou-branch requested a deployment to community-ci GitHub Actions Waiting aharbunou-branch had a problem deploying to community-ci GitHub Actions Error 
aharbunou-branch temporarily deployed to community-ci GitHub Actions Inactive aharbunou-branch temporarily deployed to community-ci GitHub Actions Inactive aharbunou-branch temporarily deployed to community-ci-auto GitHub Actions Inactive aharbunou-branch temporarily deployed to community-ci-auto GitHub Actions Inactive 
Contributor
| @aharbunou-branch running CI tests let's wait for the results. |
theyueli approved these changes Jul 2, 2024
Contributor
theyueli left a comment
theyueli left a comment There was a problem hiding this comment.
Thanks for your contribution!
aharbunou-branch temporarily deployed to community-ci GitHub Actions Inactive aharbunou-branch temporarily deployed to community-ci-auto GitHub Actions Inactive aharbunou-branch temporarily deployed to community-ci-auto GitHub Actions Inactive aharbunou-branch temporarily deployed to community-ci GitHub Actions Inactive aharbunou-branch temporarily deployed to community-ci-auto GitHub Actions Inactive aharbunou-branch temporarily deployed to community-ci-auto GitHub Actions Inactive aharbunou-branch had a problem deploying to community-ci GitHub Actions Error aharbunou-branch had a problem deploying to community-ci GitHub Actions Error aharbunou-branch temporarily deployed to community-ci-auto GitHub Actions Inactive aharbunou-branch temporarily deployed to community-ci GitHub Actions Inactive aharbunou-branch temporarily deployed to community-ci-auto GitHub Actions Inactive aharbunou-branch temporarily deployed to community-ci GitHub Actions Inactive Contributor Author
@marcosmarxm does CI look good? Is there anything else I need to do before the PR can be merged? |
Contributor
| @aharbunou-branch ask you to not update the branch as it will cancel the CI and will require me to start it again. |
| Do we know when this will be deployed? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What
Addressing existed issue #14615
How
I used destination Snowflake connector implementation as a reference to support key pair auth for source connector.
https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/destination-snowflake
Review guide
y.jsonx.javaUser Impact
Users will be able to connect to Snowflake via Key Pair auth method.
There is no breaking changes.
Can this PR be safely reverted and rolled back?