Remove custom debezium mssql converted for datetimeoffset type #39342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Closed
1 task
| The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii added area/connectors octavia-squidington-iii added the area/documentation 
evantahler approved these changes Jun 7, 2024
Contributor
evantahler left a comment
evantahler left a comment There was a problem hiding this comment.
I love deleting code!
The tests confirm things still work.
Contributor Author
| We need to take at some point a good look at our custom converters. |
This was referenced Jun 7, 2024
Closed
kabeer27 pushed a commit to kabeer27/airbyte that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We convert
datetimeoffsettypes in debezium incorrectly. assuming 7 decimal digits (precision).The conversion doesn't appear to be adding any value as defaults / nulls are handled correctly now by debezium.
Removing custom conversion of this type.
The string representation of a datetimeoffset during initial snapshot is identical to the one now coming from the debezium default converter:
2024-05-10 19:00:01.604805 +03:00(note the 6 precision digits)