source-qonto: Turn API key into a required secret #38468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii added area/connectors 
killthekitten temporarily deployed to community-ci-auto 
GitHub Actions Inactive killthekitten had a problem deploying to community-ci GitHub Actions Error killthekitten temporarily deployed to community-ci-auto GitHub Actions Inactive 
marcosmarxm approved these changes Jun 5, 2024
Contributor
marcosmarxm left a comment
marcosmarxm left a comment There was a problem hiding this comment.
Thanks @killthekitten
marcosmarxm had a problem deploying to community-ci-auto GitHub Actions Error marcosmarxm had a problem deploying to community-ci-auto GitHub Actions Error octavia-squidington-iii added the area/documentation marcosmarxm temporarily deployed to community-ci-auto GitHub Actions Inactive marcosmarxm temporarily deployed to community-ci-auto GitHub Actions Inactive 
marcosmarxm temporarily deployed to community-ci-auto GitHub Actions Inactive marcosmarxm temporarily deployed to community-ci-auto GitHub Actions Inactive 
Contributor
| Hello 👋 , your feedback matters a lot to us. Can you spare just 3 minutes to complete a survey? We're dedicated to making the contributor experience even better, and your input is key to achieving excellence. Thank you for helping us improve! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What
This patch makes the
api_keyparameter of the Qonto source required and marks it as a secretHow
The manifest.yaml has been changed accordingly
Review guide
I haven't tested the changes locally. I'd appreciate if someone else could do this during a review:
User Impact
We saw that the update from 0.1.0 to 0.2.0 dropped the API key and we had to re-add it. Would this require re-adding the API key again since it is now a secret?
Also, can we ask for a version bump consent in the UI?
Can this PR be safely reverted and rolled back?