Skip to content

Conversation

@AnjayGoel
Copy link
Contributor

@AnjayGoel AnjayGoel commented May 19, 2024

What

Migrate from obsolete V1 API to V2.
Fixes #37403, #35667, #32446.

How

Appsflyer has deprecated & removed the V1 APIs. This PR migrates the connector to the API V2.

Review guide

User Impact

Users will have to replace the API V1 tokens with API V2 tokens as described here.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌
@vercel
Copy link

vercel bot commented May 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 3:20pm
@CLAassistant
Copy link

CLAassistant commented May 19, 2024

CLA assistant check
All committers have signed the CLA.

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/appsflyer labels May 19, 2024
@AnjayGoel AnjayGoel temporarily deployed to community-ci-auto May 19, 2024 09:56 — with GitHub Actions Inactive
@AnjayGoel AnjayGoel had a problem deploying to community-ci-auto May 19, 2024 09:56 — with GitHub Actions Failure
@AnjayGoel AnjayGoel temporarily deployed to community-ci-auto May 19, 2024 10:03 — with GitHub Actions Inactive
@AnjayGoel AnjayGoel temporarily deployed to community-ci-auto May 19, 2024 10:03 — with GitHub Actions Inactive
@AnjayGoel AnjayGoel temporarily deployed to community-ci-auto May 19, 2024 10:25 — with GitHub Actions Inactive
@AnjayGoel AnjayGoel temporarily deployed to community-ci-auto May 19, 2024 10:25 — with GitHub Actions Inactive
@AnjayGoel AnjayGoel temporarily deployed to community-ci-auto May 19, 2024 10:38 — with GitHub Actions Inactive
@AnjayGoel AnjayGoel temporarily deployed to community-ci-auto May 19, 2024 10:38 — with GitHub Actions Inactive
@AnjayGoel AnjayGoel changed the title 🚨🚨🐛 Source Appsflyer: Migrate to V2 Appsflyer API 🚨 Source Appsflyer: Migrate to V2 Appsflyer API May 19, 2024
@natikgadzhi
Copy link
Contributor

@AnjayGoel thank you for contributing! Running CI on this now.

I'd like to remove the dockerfile and setup.py while we're here — would you mind rebasing if/when I ping you?

@natikgadzhi
Copy link
Contributor

@marcosmarxm, this one needs a breaking change migration guide:

source-appsflyer - ❌ Failed - Breaking changes must be accompanied by a migration guide: Migration guide file is missing for source-appsflyer. Please create a migration guide in ./docs/integrations/<connector-type>s/<connector-name>-migrations.md`. source-appsflyer - ❌ Failed - Breaking change deadline should be a week in the future: The upgrade deadline for the breaking changes in 0.2.0 is less than 7 days from today. Please extend the deadline. source-appsflyer - ❌ Failed - Connector version in metadata.yaml and pyproject.toml file must match: Version is 0.2.0 in metadata.yaml, but version is 0.1.1 in pyproject.toml. These two files have to be consistent. Error: 3 checks failed 

Can you link breaking change migration guide docs so @AnjayGoel can write one?

@AnjayGoel, this also needs version to be set in both pyproject.toml and metadata.

AnjayGoel added 3 commits June 7, 2024 20:39
# Conflicts: #	airbyte-integrations/connectors/source-appsflyer/metadata.yaml #	docs/integrations/sources/appsflyer.md
@AnjayGoel AnjayGoel temporarily deployed to community-ci-auto June 7, 2024 15:15 — with GitHub Actions Inactive
@AnjayGoel AnjayGoel temporarily deployed to community-ci-auto June 7, 2024 15:15 — with GitHub Actions Inactive
@AnjayGoel
Copy link
Contributor Author

@natikgadzhi I have made the changes

@marcosmarxm
Copy link
Contributor

Triggered CI Tests.

@marcosmarxm marcosmarxm merged commit 86549e8 into airbytehq:master Jun 10, 2024
@marcosmarxm
Copy link
Contributor

Hello your feedback matters a lot to us. Can you spare just 3 minutes to complete a survey? We're dedicated to making the contributor experience even better, and your input is key to achieving excellence. Thank you for helping us improve!

@aalkuatova
Copy link
Contributor

Hello! Thank you so much for the recent update to the new version. I've been looking forward for this release, especially as I've encountered issues with the organic_in_app_events stream. After upgrading Appsflyer to version 0.2.0, unfortunately, I'm still experiencing the same problem with this stream.
The error I'm encountering in the logs is as follows:
400 Client Error: Bad Request for URL: https://rawdata.appsflyer.com/export/token/lego_test__organic-in-app-events_2024-06-10_2024-06-11_JMQHXSDLCBLSWFW
I've manually tested this endpoint and didn't encounter any issues with API limits or etc. Could you please help me in diagnosing and resolving this issue?
Thank you !

@marcosmarxm
Copy link
Contributor

@aalkuatova do you have a github issue or can you opena. new one to further investigation?

@AnjayGoel
Copy link
Contributor Author

Hi @marcosmarxm @aalkuatova , I have raised a PR to fix this: #39407

kabeer27 pushed a commit to kabeer27/airbyte that referenced this pull request Jun 12, 2024
Co-authored-by: Natik Gadzhi <natik@respawn.io> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/appsflyer

10 participants