Destinations CDK: Add interfaces for operations by responsibility #38107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Contributor Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
2 tasks
gisripa force-pushed the cdk-ops-refactor branch 2 times, most recently from 726b1fe to 75b2191 Compare This was referenced May 10, 2024
gisripa changed the base branch from edgao/catalog_parser_improvements to cdk_generation_id This was referenced May 12, 2024
gisripa changed the base branch from cdk_generation_id to gireesh/05-10-Bigquery_cdk_signature_changes gisripa force-pushed the gireesh/05-10-Bigquery_cdk_signature_changes branch from cf090a7 to 9c0dfc5 Compare gisripa force-pushed the gireesh/05-10-Bigquery_cdk_signature_changes branch from 9c0dfc5 to 4328f0a Compare gisripa force-pushed the gireesh/05-10-Bigquery_cdk_signature_changes branch from 4328f0a to 3de0d51 Compare gisripa force-pushed the gireesh/05-10-Bigquery_cdk_signature_changes branch from 3de0d51 to 6bf8684 Compare Base automatically changed from gireesh/05-10-Bigquery_cdk_signature_changes to master May 13, 2024 18:09
edgao force-pushed the cdk-ops-refactor branch 2 times, most recently from f40bd48 to e7f388f Compare gisripa force-pushed the cdk-ops-refactor branch 3 times, most recently from 2f3380f to 4d2fbca Compare edgao force-pushed the cdk-ops-refactor branch 3 times, most recently from 23be58e to 168f866 Compare gisripa force-pushed the cdk-ops-refactor branch 3 times, most recently from ee99124 to 130b089 Compare gisripa changed the title gisripa force-pushed the cdk-ops-refactor branch 2 times, most recently from 692bc34 to fb905b5 Compare edgao force-pushed the cdk-ops-refactor branch 3 times, most recently from ae5741a to c8281d5 Compare 
edgao approved these changes May 17, 2024
2 tasks
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What
New interfaces to plug into the existing
AsyncStreamConsumer.Review guide
Minor cleanup of Existing code.
TyperDeduperTransaction.ktand unified the methods toTyperDeduperUtil.ktTyperDeduperUtilfromclasstoobjectNew code.
SyncOperation,StreamOperation,StorageOperation(see sequence diagram).DefaultSyncOperation- Sync level orchestration logicAbstractStreamOperation- Stream specific orchestration logicStagingStreamOperation- Concrete implementation acceptsSerializableBufferfor all staging destinationsStandardStreamOperation- Pass through implementation which usingStream<PartialAirbyteMessage>as the records data typeStorageOperation- See reference implementationBigQueryStorageOperationin Destination BigQuery: Adapt to newer interface for Sync operations #38132User Impact
Can this PR be safely reverted and rolled back?