Skip to content

Conversation

@artem1205
Copy link
Contributor

@artem1205 artem1205 commented Apr 22, 2024

What

Resolving https://github.com/airbytehq/airbyte-internal-issues/issues/6831

How

  • add unit tests to increase coverage up to 90%+.
  • filter files by start date

Review guide

  1. airbyte-integrations/connectors/source-azure-blob-storage/unit_tests/test_authenticator.py
  2. airbyte-integrations/connectors/source-azure-blob-storage/unit_tests/test_stream_reader.py
  3. airbyte-integrations/connectors/source-azure-blob-storage/unit_tests/test_config_migration.py

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 self-assigned this Apr 22, 2024
@vercel
Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 9:20pm
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Apr 22, 2024
@artem1205 artem1205 marked this pull request as ready for review April 22, 2024 17:05
@octavia-squidington-iv octavia-squidington-iv requested review from a team April 22, 2024 20:55
@artem1205 artem1205 force-pushed the artem1205/source-azure-blob-storage-cert branch from 85e950d to 04df48b Compare April 22, 2024 21:20
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 merged commit abba3a7 into master Apr 28, 2024
@artem1205 artem1205 deleted the artem1205/source-azure-blob-storage-cert branch April 28, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants