Source Klaviyo: update Campaigns schema #36989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
| The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii added area/connectors [skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
octavia-squidington-iii added the area/documentation ![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me!
- Reviewed the entire pull request up to 604f042
- Looked at
77lines of code in4files - Took 1 minute and 19 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
4additional comments because they didn't meet confidence threshold of50%.
1. airbyte-integrations/connectors/source-klaviyo/metadata.yaml:11:
- Assessed confidence :
0% - Comment:
The base image and version have been updated correctly. - Reasoning:
The PR author has updated the base image and version in metadata.yaml and pyproject.toml files. The schema for 'campaigns' has been updated to include 'included' and 'excluded' properties under 'audiences'. The changelog in the documentation has been updated to reflect these changes. Everything seems to be in order.
2. airbyte-integrations/connectors/source-klaviyo/pyproject.toml:6:
- Assessed confidence :
0% - Comment:
The version has been updated correctly. - Reasoning:
The version in pyproject.toml has been updated correctly.
3. airbyte-integrations/connectors/source-klaviyo/source_klaviyo/schemas/campaigns.json:20:
- Assessed confidence :
0% - Comment:
The schema for 'campaigns' has been updated correctly. - Reasoning:
The schema for 'campaigns' has been updated to include 'included' and 'excluded' properties under 'audiences'. This seems to be in line with the PR description.
4. docs/integrations/sources/klaviyo.md:66:
- Assessed confidence :
0% - Comment:
The changelog has been updated correctly. - Reasoning:
The changelog in the documentation has been updated to reflect the changes made in this PR. This is good practice.
Workflow ID: wflow_NBqXyzgZ4xAeE8hp
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
| Skipped PR review on 4e18f9f because no changed files had a supported extension. If you think this was in error, please contact us and we'll fix it right away. Generated with ❤️ by ellipsis.dev |
askarpets approved these changes Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What
resolve https://github.com/airbytehq/oncall/issues/4773
How
fix schema
Summary:
This PR updates the
Campaignsschema in the Klaviyo source connector, updates the base image and version, and reflects these changes in the changelog.Key points:
Campaignsschema incampaigns.json.metadata.yamlandpyproject.toml.klaviyo.md.Generated with ❤️ by ellipsis.dev