Skip to content

✨ [source-zendesk-support] Fix the fields data type to include the id and value #36388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 25, 2024
Merged

✨ [source-zendesk-support] Fix the fields data type to include the id and value #36388

merged 6 commits into from
Apr 25, 2024

Conversation

@mohamagdy
Copy link
Contributor

@mohamagdy mohamagdy commented Mar 22, 2024 •
edited
Loading

Set the JSON data type type of fields field items in Zendesk Support Tickets API
@vercel
Copy link

vercel bot commented Mar 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 0:51am
@marcosmarxm marcosmarxm changed the title Fix the fields data type to include the id and value ✨ [source-zendesk-support] Fix the fields data type to include the id and value Mar 22, 2024
@marcosmarxm
Copy link
Contributor

marcosmarxm commented Mar 22, 2024

@mohamagdy please update the pull request description. Can you link the Zendesk documentation showing the field is valid? Did you run tests confirming the API actually return these values?
@mohamagdy
Copy link
Contributor Author

mohamagdy commented Mar 25, 2024

@marcosmarxm thanks for taking a look into this PR. Unfortunately, I can't find the fields field in Zendesk documentation here https://developer.zendesk.com/api-reference/ticketing/tickets/tickets/#json-format. And yes, I can see the fields field returned from the API. What I noticed is that the values of the custom_fields and fields are the same (maybe this was for my case only). Maybe the fields and custom_fields are aliases, not sure 😕
@marcosmarxm
Copy link
Contributor

marcosmarxm commented Mar 25, 2024

@mohamagdy any chance to contact Zendesk to make clear this distinction? Would be quite helpful if you could this :)
@mohamagdy
Copy link
Contributor Author

mohamagdy commented Apr 2, 2024

@marcosmarxm I asked Zendesk Customer Service and they pointed me to this page https://support.zendesk.com/hc/en-us/articles/4408886739098-About-ticket-fields saying that the fields field should contain the Standard Fields but the custom_fields should contain the Custom Fields.
marcosmarxm
marcosmarxm suggested changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change than ready to go.
mohamagdy and others added 2 commits April 22, 2024 18:10
@mohamagdy @marcosmarxm
Update airbyte-integrations/connectors/source-zendesk-support/source_…
6f033e7 
…zendesk_support/schemas/shared/tickets.json Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
@lazebnyi
Merge branch 'master' into fix-zendesk-tickets-fields-data-type
d4d175d
@lazebnyi lazebnyi mentioned this pull request Apr 25, 2024
Closed
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Apr 25, 2024
@lazebnyi lazebnyi self-requested a review April 25, 2024 10:09
lazebnyi
lazebnyi approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

After @marcosmarxm approve can be merged
@lazebnyi lazebnyi enabled auto-merge (squash) April 25, 2024 10:10
@lazebnyi lazebnyi disabled auto-merge April 25, 2024 12:24
@lazebnyi lazebnyi merged commit 135e623 into airbytehq:master Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation certified community connectors/source/zendesk-support gl gl-review team/connectors-python

4 participants

@mohamagdy @marcosmarxm @lazebnyi @octavia-squidington-iii