Skip to content

Conversation

@rodireich
Copy link
Contributor

Release source-mssql 4.0.0 as a breaking change letting user opt-in

@vercel
Copy link

vercel bot commented Mar 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2024 10:43pm
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 7, 2024
@rodireich rodireich marked this pull request as ready for review March 7, 2024 06:00
@rodireich rodireich requested a review from a team as a code owner March 7, 2024 06:00
@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 7, 2024 06:01
Comment on lines 31 to 33
4.0.0:
message: "Beta release of certified source mssql connector."
upgradeDeadline: "2024-04-07"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should call it a beta release if it is going to everyone. Isn't this a regular release, but folks have some time to opt-into using it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it's GA really.


| Version | Date | Pull Request | Subject |
|:--------|:-----------|:------------------------------------------------------------------------------------------------------------------|:------------------------------------------------------------------------------------------------------------------------------------------------|
| 4.0.0 | 2024-03-06 | [35873](https://github.com/airbytehq/airbyte/pull/35873) | Beta release. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be more specific here, listing new features and why it is a breaking change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed mentions of Beta and added details.

supportLevel: community
tags:
- language:java
- language:python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not python!

@rodireich rodireich changed the title Beta release 4.0.0 GA release 4.0.0 Mar 7, 2024
releases:
breakingChanges:
4.0.0:
message: "Certified source mssql connector."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you say certified here, then you need to change line 25 too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to write something along the lines of
"We have overhauled our MSSQL source connector and it is now supported by the Airbyte team! To benefit from new features, including terabyte-sized table support, reliability improvements, expanded datetime data types, and various bug fixes, please opt in to the 4.0.0 version."

enabled: true
releaseStage: alpha
releaseStage: generally_available
supportLevel: community
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very confusing that we are highlighting it as "certified' but keeping it community

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @katmarkham . I understand that
But we're on our way to certified.
If GA works well and no major issues found we will officially certify it.

breakingChanges:
4.0.0:
message: "Certified source mssql connector."
upgradeDeadline: "2024-04-07"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think scopedImpact is applicable here.
There's no stream name that is breaking

# Microsoft SQL Server (MSSQL)
Airbyte's certified MySQL connector offers the following features:
* Multiple methods of keeping your data fresh, including [Change Data Capture (CDC)](https://docs.airbyte.com/understanding-airbyte/cdc) using the [binlog](https://dev.mysql.com/doc/refman/8.0/en/binary-log.html).
* All available [sync modes](https://docs.airbyte.com/cloud/core-concepts#connection-sync-modes), providing flexibility in how data is delivered to your destination.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's be specific here about sync mode types

#### 3. Your database user should now be ready for use with Airbyte!

#### Airbyte Cloud
On Airbyte Cloud, only secured connections to your MSSQL instance are supported in source configuration, Either by configuring you connection usign one of the supported SSL Methods or by using an SSH Tunnel.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling errors
On Airbyte Cloud, only secured connections to your MSSQL instance are supported in source configuration. You may either configure your connection using one of the supported SSL Methods or by using an SSH Tunnel.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

## Change Data Capture \(CDC\)

We use [SQL Server's change data capture feature](https://docs.microsoft.com/en-us/sql/relational-databases/track-changes/about-change-data-capture-sql-server?view=sql-server-2017) to capture row-level `INSERT`, `UPDATE` and `DELETE` operations that occur on cdc-enabled tables.
We use [SQL Server's change data capture feature](https://docs.microsoft.com/en-us/sql/relational-databases/track-changes/about-change-data-capture-sql-server?view=sql-server-2017) with transaction logs to capture row-level `INSERT`, `UPDATE` and `DELETE` operations that occur on cdc-enabled tables.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

capitalize CDC


- Make sure to read our [CDC docs](../../understanding-airbyte/cdc.md) to see limitations that impact all databases using CDC replication.
- There are some critical issues regarding certain datatypes. Please find detailed info in [this Github issue](https://github.com/airbytehq/airbyte/issues/4542).
- `hierarchyid` and `sql_variant` types are not processed in CDC migration type (not supported by debezium). For more details please check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debezium


| Version | Date | Pull Request | Subject |
|:--------|:-----------|:------------------------------------------------------------------------------------------------------------------|:------------------------------------------------------------------------------------------------------------------------------------------------|
| 4.0.0 | 2024-03-06 | [35873](https://github.com/airbytehq/airbyte/pull/35873) | Terabyte sized tables support, reliability improvements, bug fixes. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terabyte-sized tables support, reliability improvements, bug fixes.

releases:
breakingChanges:
4.0.0:
message: "Certified source mssql connector."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to write something along the lines of
"We have overhauled our MSSQL source connector and it is now supported by the Airbyte team! To benefit from new features, including terabyte-sized table support, reliability improvements, expanded datetime data types, and various bug fixes, please opt in to the 4.0.0 version."

# Microsoft SQL Server (MSSQL) Migration Guide

## Upgrading to 4.0.0
Source MSSQL provides Incremental sync that can read unlimited sized table and can resume if initial read has failed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source MSSQL provides incremental sync that can read unlimited sized tables and can resume if the initial read has failed.
Upgrading from previous versions will be seamless and does not require any intervention.

@@ -1,4 +1,9 @@
# Microsoft SQL Server (MSSQL)
Airbyte's certified MySQL connector offers the following features:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Airbyte's certified MSSQL connector offers the following features:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😳

@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 7, 2024 21:18
@rodireich rodireich merged commit eabf39c into master Mar 7, 2024
@rodireich rodireich deleted the 2912-publish-source-mssql-400 branch March 7, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mssql

5 participants